Skip to content

Commit c576a20

Browse files
authored
Remove id-kp-clientAuth from intermediate ceremony (#8265)
Fixes #8264
1 parent 5ddd5ac commit c576a20

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

cmd/ceremony/cert.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -305,12 +305,11 @@ func makeTemplate(randReader io.Reader, profile *certProfile, pubKey []byte, tbc
305305
case crlCert:
306306
cert.IsCA = false
307307
case requestCert, intermediateCert:
308-
// id-kp-serverAuth and id-kp-clientAuth are included in intermediate
309-
// certificates in order to technically constrain them. id-kp-serverAuth
310-
// is required by 7.1.2.2.g of the CABF Baseline Requirements, but
311-
// id-kp-clientAuth isn't. We include id-kp-clientAuth as we also include
312-
// it in our end-entity certificates.
313-
cert.ExtKeyUsage = []x509.ExtKeyUsage{x509.ExtKeyUsageClientAuth, x509.ExtKeyUsageServerAuth}
308+
// id-kp-serverAuth is included in intermediate certificates, as required by
309+
// Section 7.1.2.10.6 of the CA/BF Baseline Requirements.
310+
// id-kp-clientAuth is excluded, as required by section 3.2.1 of the Chrome
311+
// Root Program Requirements.
312+
cert.ExtKeyUsage = []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth}
314313
cert.MaxPathLenZero = true
315314
case crossCert:
316315
cert.ExtKeyUsage = tbcs.ExtKeyUsage

cmd/ceremony/cert_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,8 @@ func TestMakeTemplateRoot(t *testing.T) {
133133
cert, err = makeTemplate(randReader, profile, pubKey, nil, intermediateCert)
134134
test.AssertNotError(t, err, "makeTemplate failed when everything worked as expected")
135135
test.Assert(t, cert.MaxPathLenZero, "MaxPathLenZero not set in intermediate template")
136-
test.AssertEquals(t, len(cert.ExtKeyUsage), 2)
137-
test.AssertEquals(t, cert.ExtKeyUsage[0], x509.ExtKeyUsageClientAuth)
138-
test.AssertEquals(t, cert.ExtKeyUsage[1], x509.ExtKeyUsageServerAuth)
136+
test.AssertEquals(t, len(cert.ExtKeyUsage), 1)
137+
test.AssertEquals(t, cert.ExtKeyUsage[0], x509.ExtKeyUsageServerAuth)
139138
}
140139

141140
func TestMakeTemplateRestrictedCrossCertificate(t *testing.T) {

0 commit comments

Comments
 (0)