Recognize, but do not process, issuevmc CAA tags #8374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
reviewed
Sep 8, 2025
There was a problem hiding this comment.
To reduce duplication, I'd prefer that you collapse "issuevmc" onto line 205, so it would look something like:
case "issuemail", "issuevmc":
// We support these property tags insofar as we recognize them and
// therefore do not bail out if someone has one marked critical. But
// of course we do not do any further processing, as we do not issue
// S/MIME or VMC certificates.
continue
aarongable
requested review from
a team and
jsha
and removed request for
a team
jsha
approved these changes
Sep 12, 2025
aarongable
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost a copy of #7307.
Fixes #8373