More than one principals not working as expected, I mean the functionality is ok but it creates mutiple resource share

[rajamecs]

Hi ,
I see your module creates resource share for each of the principals. I have the rule as specified below. It creates two resources to share but the principals are getting added to one of those tow resource shares created. This leave one resource share unnecessary created. Ideally is it not enough to create a resource share for each rule ? ... Any ways I have corrected this let me know if i can submit a PR for the same if you allow me access ?

{ rule_name = "r53r-rule-1"
domain_name = "sage.securitysvcs.verizon.com"
ram_name = "${local.name}-ram-1"
vpc_ids = [ data.aws_vpc.this.id]
ips = ["10.x.y.z", "10.x1.y1.z1"]
principals = ["xxxxxxxxxx", "yyyyyyyyy"]
},

[AbiAb]

Hi, I have still the issue of creating multiple resource share when there are multiple principals id. Is this issue solved?
resource "aws_ram_resource_share" "endpoint_share" {
count = length(local.ram_associations)
name = lookup(element(local.rules, count.index), "ram_name")
allow_external_principals = false
}