Merge pull request #1505 from liam-hq/devin/1745550064-remove-jobs-knip-ignores

refactor: Remove jobs package files from knip ignore and fix unused code

Author: junkisai

frontend/apps/app/features/migrations/actions/resolveReviewFeedback.ts

@@ -1,11 +1,34 @@
 'use server'
 
 import { type SupabaseClient, createClient } from '@/libs/db/server'
+import type { Tables } from '@liam-hq/db/supabase/database.types'
 import { generateKnowledgeFromFeedbackTask } from '@liam-hq/jobs'
-import type { Review, ReviewFeedback } from '@liam-hq/jobs/src/types'
-import { categoryToKind } from '@liam-hq/jobs/src/utils/categoryUtils'
+import type { Review } from '@liam-hq/jobs/src/types'
 import * as v from 'valibot'
 
+type ReviewFeedback = Tables<'review_feedbacks'>
+
+type KindEnum =
+  | 'Migration Safety'
+  | 'Data Integrity'
+  | 'Performance Impact'
+  | 'Project Rules Consistency'
+  | 'Security or Scalability'
+
+function categoryToKind(category: string | null | undefined): KindEnum {
+  if (!category) return 'Migration Safety' // Default value
+
+  const mapping: Record<string, KindEnum> = {
+    MIGRATION_SAFETY: 'Migration Safety',
+    DATA_INTEGRITY: 'Data Integrity',
+    PERFORMANCE_IMPACT: 'Performance Impact',
+    PROJECT_RULES_CONSISTENCY: 'Project Rules Consistency',
+    SECURITY_OR_SCALABILITY: 'Security or Scalability',
+  }
+
+  return mapping[category] || 'Migration Safety'
+}
+
 const requestSchema = v.object({
   feedbackId: v.pipe(v.string()),
   resolutionComment: v.optional(v.nullable(v.string())),

frontend/packages/jobs/package.json

@@ -13,7 +13,6 @@
     "@trigger.dev/build": "3.3.17",
     "@trigger.dev/sdk": "3.3.17",
     "@valibot/to-json-schema": "1.0.0",
-    "langfuse": "3.37.2",
     "langfuse-langchain": "3.37.2",
     "minimatch": "10.0.1",
     "uuid": "11.1.0",

frontend/packages/jobs/src/functions/processGenerateDocsSuggestion.ts

@@ -14,7 +14,7 @@ export const DOC_FILES = [
   'migrationOpsContext.md',
 ] as const
 
-export type DocFile = (typeof DOC_FILES)[number]
+type DocFile = (typeof DOC_FILES)[number]
 
 export async function processGenerateDocsSuggestion(payload: {
   review: Review

frontend/packages/jobs/src/jobs/helloworld.ts

@@ -16,7 +16,7 @@ export const evaluationSchema = object({
 })
 
 // Define a file content with reasoning structure that can be reused
-export const fileContentSchema = object({
+const fileContentSchema = object({
   content: string(),
   reasoning: string(),
 })

frontend/packages/jobs/src/prompts/generateDocsSuggestion/docsSuggestionSchema.ts

@@ -8,7 +8,7 @@ const KindEnum = enumType({
   'Security or Scalability': 'Security or Scalability',
 })
 
-export const SeverityEnum = enumType({
+const SeverityEnum = enumType({
   CRITICAL: 'CRITICAL',
   WARNING: 'WARNING',
   POSITIVE: 'POSITIVE',

frontend/packages/jobs/src/prompts/generateDocsSuggestion/index.ts

@@ -2,8 +2,3 @@ export { savePullRequestTask } from './savePullRequest'
 export { generateReviewTask } from './generateReview'
 export { saveReviewTask } from './saveReview'
 export { postCommentTask } from './postComment'
-
-export { processSavePullRequest } from './savePullRequest'
-export { processGenerateReview } from './generateReview'
-export { processSaveReview } from './saveReview'
-export { postComment } from './postComment'

frontend/packages/jobs/src/prompts/generateReview/reviewSchema.ts

@@ -12,7 +12,7 @@ type SavePullRequestPayload = {
   projectId: string
 }
 
-export type SavePullRequestResult = {
+type SavePullRequestResult = {
   success: boolean
   prId: string
   repositoryId: string

frontend/packages/jobs/src/tasks/review/index.ts

@@ -89,7 +89,7 @@ export const generateSchemaOverrideSuggestionTask = task({
   },
 })
 
-export const createKnowledgeSuggestionTask = task({
+const createKnowledgeSuggestionTask = task({
   id: 'create-knowledge-suggestion',
   run: async (payload: {
     projectId: string