-
Notifications
You must be signed in to change notification settings - Fork 141
Remove try-catch blocks from app and jobs packages #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: hirotaka.miyagi@route06.co.jp <hirotaka.miyagi@route06.co.jp>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Updates to Preview Branch (devin/1745548711-remove-try-catch) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
frontend/packages/prompt-test result:
|
Co-Authored-By: hirotaka.miyagi@route06.co.jp <hirotaka.miyagi@route06.co.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
(aside) It is easier to see if you remove whitespace
.
(aside)
👍 https://github.com/liam-hq/liam/pull/1504/files?w=1 |
(aside) removed from merge-queue 😭 https://github.com/liam-hq/liam/actions/runs/14656138189/job/41131450792 ping @MH4GF |
@hoshinotsuyoshi Oh Thanks, I'll let devin-san again 👍🏻 |
Co-Authored-By: hirotaka.miyagi@route06.co.jp <hirotaka.miyagi@route06.co.jp>
to Devin |
Co-Authored-By: hirotaka.miyagi@route06.co.jp <hirotaka.miyagi@route06.co.jp>
Problem
The project contains excessive and inappropriate error handling (try-catch blocks) that cause the following issues:
Solution
This PR removes all try-catch blocks from the app and jobs packages. This is the first step in a phased approach to improve error handling in the project.
Changes
Testing
The PR passes all CI checks. No functional changes are expected as this is just removing error suppression.
Link to Devin run: https://app.devin.ai/sessions/94739262c7ab43439d4738ab3c74cada
Requested by: hirotaka.miyagi@route06.co.jp