Skip to content

Remove try-catch blocks from app and jobs packages #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Problem

The project contains excessive and inappropriate error handling (try-catch blocks) that cause the following issues:

  • Errors are being swallowed and not reported to Sentry
  • Page 404 errors are difficult to diagnose
  • Errors that should be detected are hidden

Solution

This PR removes all try-catch blocks from the app and jobs packages. This is the first step in a phased approach to improve error handling in the project.

Changes

  • Removed try-catch blocks from the app package
  • Removed try-catch blocks from the jobs package
  • Preserved core functionality while allowing errors to propagate properly
  • Did not modify notFound() function calls as requested

Testing

The PR passes all CI checks. No functional changes are expected as this is just removing error suppression.

Link to Devin run: https://app.devin.ai/sessions/94739262c7ab43439d4738ab3c74cada
Requested by: hirotaka.miyagi@route06.co.jp

Co-Authored-By: hirotaka.miyagi@route06.co.jp <hirotaka.miyagi@route06.co.jp>
Copy link

changeset-bot bot commented Apr 25, 2025

⚠️ No Changeset found

Latest commit: 7d26cee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liam-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 1:06pm
liam-erd-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 1:06pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
liam-docs ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2025 1:06pm

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

supabase bot commented Apr 25, 2025

Updates to Preview Branch (devin/1745548711-remove-try-catch) ↗︎

Deployments Status Updated
Database Fri, 25 Apr 2025 13:04:12 UTC
Services Fri, 25 Apr 2025 13:04:12 UTC
APIs Fri, 25 Apr 2025 13:04:12 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Fri, 25 Apr 2025 13:04:15 UTC
Migrations Fri, 25 Apr 2025 13:04:15 UTC
Seeding Fri, 25 Apr 2025 13:04:15 UTC
Edge Functions Fri, 25 Apr 2025 13:04:15 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

Copy link
Contributor

github-actions bot commented Apr 25, 2025

Co-Authored-By: hirotaka.miyagi@route06.co.jp <hirotaka.miyagi@route06.co.jp>
Copy link
Member

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻
(aside) It is easier to see if you remove whitespace.

@hoshinotsuyoshi
Copy link
Member

(aside)

(aside) It is easier to see if you remove whitespace.

👍 https://github.com/liam-hq/liam/pull/1504/files?w=1

@hoshinotsuyoshi hoshinotsuyoshi added this pull request to the merge queue Apr 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2025
@hoshinotsuyoshi
Copy link
Member

(aside)

removed from merge-queue 😭 https://github.com/liam-hq/liam/actions/runs/14656138189/job/41131450792

ping @MH4GF
Should we let devin-san work about this?

@MH4GF
Copy link
Member

MH4GF commented Apr 25, 2025

@hoshinotsuyoshi Oh Thanks, I'll let devin-san again 👍🏻

Co-Authored-By: hirotaka.miyagi@route06.co.jp <hirotaka.miyagi@route06.co.jp>
@FunamaYukina
Copy link
Member

to Devin
Please remove changeset.
.changeset/thirty-ties-kiss.md

Co-Authored-By: hirotaka.miyagi@route06.co.jp <hirotaka.miyagi@route06.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants