-
Notifications
You must be signed in to change notification settings - Fork 37
Ensuring goodbye packets are sent on shutdown #27
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't working
Description
As discussed here librespot-org/librespot#676 (comment) we don't seem to get "goodbye" mDNS messages when stopping the librespot process which leaves the service lingering in clients. I think it's due to this TODO:
Lines 202 to 207 in 4829c5c
| impl Drop for Shutdown { | |
| fn drop(&mut self) { | |
| self.0.send_shutdown(); | |
| // TODO wait for tasks to shutdown | |
| } | |
| } |
I had a bash at a fix, it is not pretty...
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working