Configuration in services section is not preserved after reboot

[ckwun]

Lakka Version: H3.arm-5.0

Hello,

I try to turn off SAMBA by setting

Services > SAMBA to OFF

It works fine but after rebooting it will always set to ON

Other settings in this section like SSH on/off don’t have this problem and is well preserved after reboot.

I noticed that this setting (and other settings like SSH in services section) is not save in the /storage/.config/retroarch/retroarch.cfg file like other “normal“ settings.

Maybe there is a place that I can set the SAMBA default value to OFF? That will do the job.

Thanks!

[ckwun]

Found the problem.

In file: Lakka-LibreELEC/packages/network/samba/scripts/samba-config
line 48
if [ ! -f /storage/.cache/services/samba.disabled ]; then
The problem is /storage/.cache/services/samba.disabled will never exist.

The samba toggle handler in RetroArch:

RetroArch/lakka.h
#define LAKKA_SAMBA_PATH "/storage/.cache/services/samba.conf"
RetroArch/menu/menu_setting.c
static void samba_enable_toggle_change_handler(rarch_setting_t *setting) { systemd_service_toggle(LAKKA_SAMBA_PATH, (char*)"smbd.service", *setting->value.target.boolean); }

This handler will just create/delete LAKKA_SAMBA_PATH (i.e. /storage/.cache/services/samba.conf) when toggle. It will not create /storage/.cache/services/samba.disabled when set to off.

These service files also check for /storage/.cache/services/samba.disabled
ConditionPathExists=!/storage/.cache/services/samba.disabled
Lakka-LibreELEC/packages/network/samba/system.d.opt/nmbd.service
Lakka-LibreELEC/packages/network/samba/system.d.opt/smbd.service

My current fix:
Manually add a /storage/.cache/services/samba.disabled file after setting SAMBA to off in UI.
ssh to the system and just
touch /storage/.cache/services/samba.disabled

Possible solutions:

1. Modify the logic of function samba_enable_toggle_change_handler in RetroArch/menu/menu_setting.c
2. Modify the logic of Lakka-LibreELEC/packages/network/samba/scripts/samba-config

[Ntemis]

sent a pr please

[ckwun]

sent a pr please

Done.

But there is still problems.
The /storage/.cache/services/samba.conf file will be deleted every time when SAMBA toggle to off in the UI menu. But the samba-config.service is Type=oneshot, means no re-generation of this config file to the Lakka default unless reboot. Toggle SAMBA off and then on in the menu, smbd will run using a empty config file.

Without this fix (H3.arm-5.0), this problem is even worst. If the user toogle SAMBA to off then on, a empty file /storage/.cache/services/samba.conf will be created. If the user reboot at this state, this file will always be empty (even after reboot). Unless the user toggle SAMBA to off in UI menu then reboot. (And run into this issue, SAMBA being set to ON)

Maybe someone should open a new issue for this.

[ShigeakiAsai]

Hello @ckwun
Thank you for your explanation!

My understanding for this issue is...
"Should not delete /storage/.cache/services/samba.conf under any circumstances."
"under any circumstances" means "when it changes disable or enable in SAMBA menu"

Does this match your thoughts?

[ckwun]

Hello @ckwun Thank you for your explanation!

My understanding for this issue is... "Should not delete /storage/.cache/services/samba.conf under any circumstances." "under any circumstances" means "when it changes disable or enable in SAMBA menu"

Does this match your thoughts?

This might work but it will require to modify the logic of function samba_enable_toggle_change_handler & systemd_service_toggle in another repo RetroArch/menu/menu_setting.c.

And I think the logic of these functions also responsible for determine the current on/off state display in UI and control systemd service start/stop/reload (I do not fully investigate this but I belive so).

Currently,

1. The smbd works fine with a empty samba.conf without the Lakka defaults? (Again, just my thought, not fully investigated)
2. The current UI don't have options to config the smbd anyways. So losing the samba.conf file should not be a huge problem for normal user.

I don't think is worth the risk to modify these functions just for this issue as it will most likely affect the systemd service control logic which now also works fine (set off->service stop, set on->service start).

I think just removing the line Type=oneshot in the samba-config.service file will do the trick? With my fix now it should re-generate the Lakka defaults if /storage/.cache/services/samba.conf is empty.

Any thoughts?

[ShigeakiAsai]

I got the reason about this problem.

Lakka merged the upstreamLE commit 061bb5d into Lakka tree.
"/storage/.cache/services/samba.disabled" file is added for samba enable/disable by this commit.
But RetroArch was not chatched up for this commit yet, RetroArch uses/removes "/storage/.cache/services/samba.conf" file that was used at before this commit.

@ckwun tried to fix for samba(#2099), but RetroArch should fix for this problem not samba I think.

a) RetroArch still removes "/storage/.cache/services/samba.conf"(user samba config) if samba fixed this problem.
b) This problem happeneds on not only H3.arm-5.0 but also other devices.
c) RetroArch's samba implementation is only enabled in "HAVE_LAKKA" compilation switch.

I will create pull request for this problem fix later.
https://github.com/ShigeakiAsai/Lakka-LibreELEC/tree/fix_samba_service_resurrection
This will be needed Lakka-v6.x, Lakka-v6.1 and devel branch.
I don't know Lakka-v5.x needs it or not.

About ckwun question:
Base SAMBA config uses "/etc/samba/smb.conf".
Additional(user) SAMBA config uses "/storage/.cache/services/samba.conf".
Additional(user) SAMBA config is valitated in "/usr/lib/samba/samba-config".

Note.
@ckwun
Your information was correct and very helpful.
Thank you very much!!

[ckwun]

@ShigeakiAsai

I agree with you. Retroarch should fix this instead of samba if this is cauesd by a samba update 061bb5d.

Now #2101 should fully fix the issue.

Nice work!