Skip to content

Conversation

@viachaslavic
Copy link
Contributor

@viachaslavic viachaslavic commented Dec 17, 2024

Add typos-action for changed files in PR's . Exceptions can be added to the _typos.toml config file.

@viachaslavic viachaslavic force-pushed the typos-action branch 2 times, most recently from 9472df6 to 8fbb6bd Compare December 17, 2024 01:16
@fpscan fpscan self-requested a review December 17, 2024 05:10
@viachaslavic
Copy link
Contributor Author

The current implementation of this action will display found errors in the workflow log. I think to wait for an update with a code suggestion in Sarif format.

Copy link
Member

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a reasonable addition. Tansknz!!! [/typo]

@gouchi
Copy link
Member

gouchi commented Apr 8, 2025

Could help #297

@gouchi
Copy link
Member

gouchi commented Nov 16, 2025

@viachaslavic Should be good now that Sarif report has been integrated in Typos ?

Thank you.

@viachaslavic
Copy link
Contributor Author

@gouchi Yes, the format itself is implemented, but I was thinking of waiting for integration into github-action so that a comment with the spell checking result would be automatically added to pull requests.

In fact, you can already merge it without this feature. In which case the results can be viewed in the annotations by going to Typos Action (for example, as in this PR)

@gouchi
Copy link
Member

gouchi commented Nov 17, 2025

@fpscan We should merge this PR ;)

Thank you.

@fpscan fpscan marked this pull request as ready for review November 17, 2025 21:30
@fpscan fpscan merged commit 3b3550e into libretro:master Nov 17, 2025
1 check failed
@viachaslavic viachaslavic deleted the typos-action branch November 18, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants