fixup! Add support for sending to human-readable names that resolve to Bolt12 Offers

Author: chuksys

src/config.rs

@@ -191,7 +191,9 @@ impl Default for Config {
 	}
 }
 
-/// Configuration options for Human-readable Names
+/// Configuration options for Human-Readable Names ([BIP 353]).
+/// 
+/// [BIP 353]: https://github.com/bitcoin/bips/blob/master/bip-0353.mediawiki
 #[derive(Debug, Clone)]
 pub struct HumanReadableNamesConfig {
 	/// The DNS resolvers to be used for resolving Human-Readable Names.
@@ -323,6 +325,7 @@ pub(crate) fn default_user_config(config: &Config) -> UserConfig {
 	let mut user_config = UserConfig::default();
 	user_config.channel_handshake_limits.force_announced_channel_preference = false;
 	user_config.manually_accept_inbound_channels = true;
+	user_config.manually_handle_bolt12_invoices = true;
 	user_config.channel_handshake_config.negotiate_anchors_zero_fee_htlc_tx =
 		config.anchor_channels_config.is_some();
 

src/error.rs

@@ -201,7 +201,7 @@ impl fmt::Display for Error {
 				write!(f, "Failed to parse a human-readable name.")
 			},
 			Self::DnsResolversUnavailable => {
-				write!(f, "The given operation failed due to `dns-resolvers` not being configured in builder.")
+				write!(f, "The given operation failed due to DNS resolvers not being configured.")
 			},
 		}
 	}

src/event.rs

@@ -1417,7 +1417,7 @@ where
 					);
 				}
 			},
-			LdkEvent::InvoiceReceived { payment_id, invoice, context: _, responder: _ } => {
+			LdkEvent::InvoiceReceived { payment_id, invoice, context, responder: _ } => {
 				let update = PaymentDetailsUpdate {
 					hash: Some(Some(invoice.payment_hash())),
 					quantity: invoice.quantity(),
@@ -1431,6 +1431,8 @@ where
 						return Err(ReplayEvent());
 					},
 				};
+
+				let _ = self.channel_manager.send_payment_for_bolt12_invoice(&invoice, context.as_ref());
 			},
 			LdkEvent::ConnectionNeeded { node_id, addresses } => {
 				let runtime_lock = self.runtime.read().unwrap();

src/payment/bolt12.rs

@@ -37,7 +37,7 @@ type HumanReadableName = Arc<crate::uniffi_types::HumanReadableName>;
 
 #[cfg(not(feature = "uniffi"))]
 pub fn maybe_convert_hrn(hrn: HumanReadableName) -> LdkHumanReadableName {
-	hrn.clone()
+	hrn
 }
 #[cfg(feature = "uniffi")]
 pub fn maybe_convert_hrn(hrn: HumanReadableName) -> LdkHumanReadableName {
@@ -316,7 +316,7 @@ impl Bolt12Payment {
 			destinations,
 		) {
 			Ok(()) => {
-				log_info!(self.logger, "Initiated sending {} msats to {:?}", amount_msat, hrn);
+				log_info!(self.logger, "Initiated sending {} msats to ₿{}@{}", amount_msat, hrn.user(), hrn.domain());
 				let kind = PaymentKind::Bolt12Offer {
 					hash: None,
 					preimage: None,
@@ -337,7 +337,7 @@ impl Bolt12Payment {
 				Ok(payment_id)
 			},
 			Err(()) => {
-				log_error!(self.logger, "Failed to send payment to {:?}", hrn);
+				log_error!(self.logger, "Failed to send payment to ₿{}@{}", hrn.user(), hrn.domain());
 				let kind = PaymentKind::Bolt12Offer {
 					hash: None,
 					preimage: None,

src/payment/store.rs

@@ -404,6 +404,10 @@ pub enum PaymentKind {
 		/// The secret used by the payment.
 		secret: Option<PaymentSecret>,
 		/// The ID of the offer this payment is for.
+		/// 
+		/// This will be set to `None` when sending payments to Human-Readable Names ([BIP 353]).
+		/// 
+		/// [BIP 353]: https://github.com/bitcoin/bips/blob/master/bip-0353.mediawiki
 		offer_id: Option<OfferId>,
 		/// The payer note for the payment.
 		///