-
Notifications
You must be signed in to change notification settings - Fork 116
Add support for resolving BIP 353 Human-Readable Names #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chuksys
wants to merge
12
commits into
lightningdevkit:main
Choose a base branch
from
chuksys:add-support-for-resolving-hrns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9ea92d5
Rename unified_qr to unified
chuksys b11fead
rename UnifiedQRPayment to UnifiedPayment, rename QRPaymentResult to …
chuksys 998bdab
add bitcoin-payment-instructions to cargo.toml
chuksys 55522b9
Add hrn_resolver to Node and pass into UnifiedPayment
chuksys f1d1fa1
Refactor unified.rs to support sending to BIP 21 URIs as well as BIP …
chuksys 869839a
Fix typo in unified_payment send test and improve test name.
chuksys 38e17d1
Switch to explicit imports in unified.rs mod tests
chuksys da52af8
Add lightning-dns-resolver to Cargo.toml
chuksys 7973b8c
Enable setting Node as HRN Resolver for 3rd parties in Config
chuksys 6068c1c
Pass HRNResolver or DomainResolver into OnionMessenger
chuksys 2149475
Testing Node Ann Broadcast when node is_hrn_resolver
chuksys 0517dbc
Add end-to-end test for HRN resolution
chuksys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think over at the first PR we discussed to introduce a dedicated config for HRN-related things, also to specify default resolvers, for example? Probably this should be part of such a config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we did - I'll re-introduce the dedicated config for HRN-related things.