Require both KVStore and KVStoreSync implementations, switch BP to be fully-async
#633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! This PR is now in draft status. |
tnull
force-pushed
the
2025-09-async-vss-store
branch
from
2adf4a7 to
296b55c
Compare
This was referenced Sep 12, 2025
Merged
tnull
force-pushed
the
2025-09-async-vss-store
branch
from
296b55c to
85198d8
Compare
|
This now builds based on the just-merged lightningdevkit/rust-lightning#4069. We have yet to add write-version tracking for VSS. |
tnull
force-pushed
the
2025-09-async-vss-store
branch
3 times, most recently
from
c4251d4 to
7158653
Compare
.. first step to make review easier.
.. as we're gonna reuse the `async` `_internal` methods shortly.
.. where the former holds the latter in an `Arc` that can be used in async/`Future` contexts more easily.
We implement the async `KVStore` trait for `VssStore`.
.. to be easier reusable via `KVStore` also
.. where the former holds the latter in an `Arc` that can be used in async/`Future` contexts more easily.
.. to be easier reusable via `KVStore` also
.. where the former holds the latter in an `Arc` that can be used in async/`Future` contexts more easily.
As an intermediary step, we require any store to implement both `KVStore` and `KVStoreSync`, allowing us to switch over step-by-step. We already switch to the fully-async background processor variant here.
tnull
force-pushed
the
2025-09-async-vss-store
branch
from
7158653 to
8c2ff8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an intermediary step towards making our IO fully async, we now require any store to implement both
KVStoreandKVStoreSync, which allows us to switch over to the fully-async background processor and take further migration steps bit-by-bit when we make more and more of the core codebaseasync.To this end, we refactor
VssStoreandSqliteStoreto implementKVStoreTODOs:
KVStoreforTestStoreupstream to fix testsKVStoreimplementation.. draft until then.