Rustfmt Maximalism #3749
Rustfmt Maximalism #3749
Conversation
|
👋 Thanks for assigning @jkczyz as a reviewer! |
joostjager
force-pushed
the
fmt-maximalism
branch
from
7be120f to
ad093d8
Compare
joostjager
force-pushed
the
fmt-maximalism
branch
from
ad093d8 to
3d52da9
Compare
| 'a, | ||
| 'b, | ||
| 'c, | ||
| 'd, | ||
| 'e, | ||
| 'f, | ||
| 'logger, | ||
| 'h, | ||
| 'i, | ||
| 'j, | ||
| 'graph, | ||
| 'k, | ||
| 'mr, | ||
| SD, | ||
| M, | ||
| T, | ||
| F, | ||
| C, | ||
| L, |
| flags & FundedStateFlags::ALL | ||
| == FundedStateFlags::LOCAL_SHUTDOWN_SENT |
There was a problem hiding this comment.
This fits on one line. Is there something about our config that would cause it to split it over two lines?
There was a problem hiding this comment.
The reason is that rustfmt wants to put the == on the same line, pushing the total == FundedStateFlags::LOCAL_SHUTDOWN_SENT | FundedStateFlags::REMOTE_SHUTDOWN_SENT to column 101. So expected behavior afaik.
There was a problem hiding this comment.
Ah, it's bitwise not logical OR.
|
🔔 1st Reminder Hey @TheBlueMatt @jkczyz @wpaulino! This PR has been waiting for your review. |
2 similar comments
|
🔔 1st Reminder Hey @TheBlueMatt @jkczyz @wpaulino! This PR has been waiting for your review. |
|
🔔 1st Reminder Hey @TheBlueMatt @jkczyz @wpaulino! This PR has been waiting for your review. |
| for file in $(comm -23 "$TMP_FILE" rustfmt_excluded_files); do | ||
| echo "Checking formatting of $file" | ||
| rustfmt $VERS --edition 2021 --check "$file" | ||
| done |
There was a problem hiding this comment.
CONTRIBUTING.md needs update to remove reference to contrib/run-rustfmt.sh
Just enable it globally. We can take care of format refactors later or as we update the code, and this way we immediately eliminate the ongoing formatting micro-penalties.
To auto-format in-flight PRs without manual conflict resolution:
git filter-branch --tree-filter 'cargo fmt' -f main..HEADAfter rewriting the branch, rebase onto a fully formatted main branch. For any conflicts, just choose 'theirs' (
git rebase -X theirs main)