Run rustfmt on payment_tests and functional_tests and split up the latter
#3751
+10,420
−6,995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`funtional_tests.rs` has gotten incredibly huge over the years, so here we move some channel reserve tests into a new file.
`funtional_tests.rs` has gotten incredibly huge over the years, so here we move some further channel reserve tests into a new file. We do so separately from the previous commit to ensure git identifies the changes as move-only.
`funtional_tests.rs` has gotten incredibly huge over the years, so here we move some simple HTLC unit tests into a new file.
`funtional_tests.rs` has gotten incredibly huge over the years, so here we move all the channel fee-related tests out to their own file.
|
👋 Thanks for assigning @joostjager as a reviewer! |
In general we shouldn't have tests lying around that are useless as its dead code and may break due to harmless protocol changes. Here, we drop a few useless tests.
TheBlueMatt
force-pushed
the
2025-04-rustfmt-tests-1
branch
from
293c6af to
820cb58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functional_tests' time has come, and there's some easy batches of tests to move into separate files. Even at the end its still 10k LoC, but that's better than the 14K it started as (let alone how long it'd be if it were naively rustfmt'd).