Notifications: Improve L402 handling #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sputn1ck
force-pushed
the
better_ntfn_stream_l402
branch
from
feb5bbb to
e475756
Compare
This commit changes the way we fetch the l402 tokens for the notification stream. Instead of fetching them from the server and paying an invoice, we now look into our local store for the token. This means that a loop client will not autofetch a token.
sputn1ck
force-pushed
the
better_ntfn_stream_l402
branch
from
e475756 to
b0301e4
Compare
sputn1ck
force-pushed
the
better_ntfn_stream_l402
branch
from
b0301e4 to
18b7573
Compare
This commit adds the FetchL402 rpc to the client proto, which will allow users to force fetching an L402 without doing a loop out or in.
This commit adds a new command to the loop cli tool that fetches the a l402 token from the swap server.
sputn1ck
force-pushed
the
better_ntfn_stream_l402
branch
from
18b7573 to
7ca5dc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves l402 handling for the notification stream. Prior an automatic 1sat payment was dispatched to fetch an l402 from the server. This logged unnecessary noise, when a node did not have sufficient outbound liquidity. We now check our local store
for an l402 and only continue with the stream if one token is found.
A new user will need to loop out or call the new
fetchl402cli command in order to receive notifications.