Tap channels liquidity fixes #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"Parent" PR (itest in litd) for more context & linked issues: |
Pull Request Test Coverage Report for Build 10938152046Details
💛 - Coveralls |
2 tasks
GeorgeTsagk
force-pushed
the
tap-chan-liquidity-fixes
branch
from
3e4f920 to
2ea5adb
Compare
guggero
reviewed
Sep 13, 2024
| } | ||
|
|
||
| // Get the minimum HTLC amount, which is just above dust. | ||
| minHtlcAmt := lnwire.NewMSatFromSatoshis(DefaultOnChainHtlcAmount) |
There was a problem hiding this comment.
Hmm, looking at the previous commit, I wondered if this value needed to be dynamic, based on the channel config's dust limit.
But luckily for lnd to lnd this value is always static: https://github.com/lightningnetwork/lnd/blob/b58fcf73fff36a0ac45e89fac2d7aa589fa6c47b/lnwallet/wallet.go#L1419
There was a problem hiding this comment.
I see, perhaps worth keeping track of somehow, in case we ever have tap channel between different LN node implementations
GeorgeTsagk
force-pushed
the
tap-chan-liquidity-fixes
branch
from
2ea5adb to
67b4d2e
Compare
GeorgeTsagk
force-pushed
the
tap-chan-liquidity-fixes
branch
2 times, most recently
from
1ea6175 to
a875044
Compare
guggero
approved these changes
Sep 17, 2024
GeorgeTsagk
force-pushed
the
tap-chan-liquidity-fixes
branch
from
a875044 to
ed13ed7
Compare
GeorgeTsagk
force-pushed
the
tap-chan-liquidity-fixes
branch
from
ed13ed7 to
a6f5c3e
Compare
|
|
guggero
approved these changes
Sep 19, 2024
ffranr
approved these changes
Sep 19, 2024
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some small fixes for liquidity related bugs that were reported on tap channels.