remove expired key #10157
Merged
remove expired key #10157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ziggie1984
force-pushed
the
remove-pgp-key
branch
from
6bc9e76 to
dee0f47
Compare
There was a problem hiding this comment.
Code Review
This pull request removes an expired PGP key, updates database migrations, and adds documentation for the SQL schema update process. The changes to remove the key are correct. The database migration changes introduce a new index for settled invoices and renumber the graph migrations. I've found a critical issue where development migration versions are not sequential, which could lead to database inconsistencies. I've also found a minor typo in the new documentation file. Please see my detailed comments.
ziggie1984
force-pushed
the
remove-pgp-key
branch
from
dee0f47 to
dccb669
Compare
bhandras
approved these changes
Aug 15, 2025
guggero
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove expired key.