Skip to content

Conversation

ziggie1984
Copy link
Collaborator

@ziggie1984 ziggie1984 commented Sep 4, 2025

Resulted from #9147

moved all the commits which are a refactor to this PR.

@ziggie1984 ziggie1984 force-pushed the refactor-payment-part-6 branch from b10cd64 to aa31662 Compare September 4, 2025 07:59
@ziggie1984 ziggie1984 self-assigned this Sep 4, 2025
@ziggie1984 ziggie1984 added no-changelog payments Related to invoices/payments labels Sep 4, 2025
@ziggie1984 ziggie1984 marked this pull request as ready for review September 4, 2025 08:07
@saubyk saubyk added this to lnd v0.20 Sep 4, 2025
@saubyk saubyk moved this to In progress in lnd v0.20 Sep 4, 2025
Copy link
Collaborator

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! couple of comments

@ziggie1984 ziggie1984 force-pushed the refactor-payment-part-6 branch from aa31662 to 110d1ee Compare September 5, 2025 07:51
@ziggie1984 ziggie1984 force-pushed the refactor-payment-part-6 branch from 110d1ee to ad016a1 Compare September 5, 2025 07:54
Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending linter fix

This is only used for testing because we have now a unique
contraint on the session key and need to swap it in tests for
the sql backend.
pick f17baec94 paymentsdb: fix linter
@ziggie1984 ziggie1984 force-pushed the refactor-payment-part-6 branch from ad016a1 to f540e9c Compare September 8, 2025 06:24
@ziggie1984
Copy link
Collaborator Author

Pending linter fix

Added a nolint directive to the setSessionKey function because it will only be used in the next PR.

Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🧹

@yyforyongyu yyforyongyu merged commit 6c9e0f3 into lightningnetwork:master Sep 8, 2025
34 of 39 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in lnd v0.20 Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog payments Related to invoices/payments
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants