-
Notifications
You must be signed in to change notification settings - Fork 2.2k
refactor payments part 6 #10196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor payments part 6 #10196
Conversation
b10cd64
to
aa31662
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! couple of comments
aa31662
to
110d1ee
Compare
We rename the modifier to use the same naming as used in the graphDB to align the codebase.
We don't for example want to replace CURRENT_TIMESTAMP when using it in our tables.
110d1ee
to
ad016a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending linter fix
This is only used for testing because we have now a unique contraint on the session key and need to swap it in tests for the sql backend. pick f17baec94 paymentsdb: fix linter
ad016a1
to
f540e9c
Compare
Added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🧹
Resulted from #9147
moved all the commits which are a refactor to this PR.