docs: add deprecation warning for tor.v2

[yyforyongyu]

Fix #5771. We now mark the tor.v2 as a hidden and deprecated config option. The support for v2 will be removed in the next release.

[gemini-code-assist]

Summary of Changes

Hello @yyforyongyu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses the deprecation of Tor v2 onion services by marking the corresponding configuration option as hidden and deprecated. It updates the configuration structure to prevent new usage and adds a clear warning in the release notes for version 0.20.0, informing users that support for Tor v2 will be entirely removed in the subsequent 0.21 release. This change aligns the application with the broader move away from older Tor v2 services to the more secure and robust Tor v3.

Highlights

• Deprecation of Tor v2 Configuration: The tor.v2 configuration option has been formally marked as deprecated and hidden within the application's configuration structure.
• Upcoming Removal of Tor v2 Support: Support for Tor v2 onion services will be completely removed in the next major release, version 0.21.
• Documentation Update: The release notes for version 0.20.0 have been updated to clearly inform users about the deprecation of Tor v2 and its impending removal.
• Test Coverage for Deprecation: An existing configuration test (TestConfigToFlatMap) was updated to ensure that tor.v2 is correctly identified and handled as a deprecated option.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly marks the tor.v2 configuration option as deprecated and hidden, updating the release notes and tests accordingly. The changes are straightforward and align with the goal of removing Tor v2 support in a future release. I've added one suggestion to improve the clarity of the deprecation message for users.

[yyforyongyu]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly marks the tor.v2 configuration option as deprecated and hidden, updates the test suite to reflect this, and adds a corresponding entry to the release notes. My review focuses on improving the clarity and accuracy of the deprecation messages. I've suggested making the deprecation notice in the configuration more specific about the removal version and pointed out a potentially incorrect link in the release notes.

[yyforyongyu]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly marks the tor.v2 configuration option as deprecated and hidden, in preparation for its removal in a future release. The changes include updating the configuration definition, adjusting a test to verify the deprecation, and adding a note to the release documentation. The implementation is sound. I have one minor suggestion to improve the wording of the release note for better clarity.

[yyforyongyu]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly marks the tor.v2 configuration option as deprecated and hidden, in preparation for its removal in a future release. The changes are well-contained and include updating the configuration struct tag in lncfg/tor.go, adding a test case in config_test.go to verify the deprecation logic, and adding a clear note to the release notes in docs/release-notes/release-notes-0.20.0.md. The implementation is straightforward and correct. I have one minor suggestion to improve comment accuracy in the test file.

[ziggie1984]

LGTM