Skip to content

lnwire: detect invalid timestamp field #9084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024
Merged

lnwire: detect invalid timestamp field #9084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1a6d3a
lnwire: fail decoding on incorrect number of timestamps
morehouse Sep 10, 2024
532fe05
discovery: remove check for incorrect number of timestamps
morehouse Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions discovery/syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,12 +835,6 @@ func (g *GossipSyncer) processChanRangeReply(msg *lnwire.ReplyChannelRange) erro
}

g.prevReplyChannelRange = msg
if len(msg.Timestamps) != 0 &&
len(msg.Timestamps) != len(msg.ShortChanIDs) {

return fmt.Errorf("number of timestamps not equal to " +
"number of SCIDs")
}

for i, scid := range msg.ShortChanIDs {
info := channeldb.NewChannelUpdateInfo(
Expand Down
6 changes: 6 additions & 0 deletions lnwire/reply_channel_range.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@ func (c *ReplyChannelRange) Decode(r io.Reader, pver uint32) error {
// Set the corresponding TLV types if they were included in the stream.
if val, ok := typeMap[TimestampsRecordType]; ok && val == nil {
c.Timestamps = timeStamps

// Check that a timestamp was provided for each SCID.
if len(c.Timestamps) != len(c.ShortChanIDs) {
return fmt.Errorf("number of timestamps does not " +
"match number of SCIDs")
}
}

if len(tlvRecords) != 0 {
Expand Down
Loading