[1/2] discovery+lnwire: add support for DNS host name in NodeAnnouncement msg #9455

mohamedawnallah · 2025-01-29T01:48:15Z

Change Description

Towards #6337.
Towards #9126.
Next #10159.

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

Your PR passes all CI checks.
Tests covering the positive and negative (error paths) are included.
Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
Commits follow the Ideal Git Commit Structure.
Any new logging statements use an appropriate subsystem and logging level.
Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our Contribution Guidelines for further guidance.

coderabbitai · 2025-01-29T01:48:23Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

graph/db/addr.go

sample-lnd.conf

lnrpc/lightning.proto

cmd/commands/peersrpc_active.go

config.go

mohamedawnallah · 2025-05-05T12:59:39Z

This PR is not yet ready for review. It looks like more code paths need to be test-covered. I also understand the git commit structure is not still followed per latest feedback as I was trying to make CI happy. I will take a look at this PR soon.

mohamedawnallah · 2025-05-11T22:59:05Z

Thank you, @ellemouton, for your feedback on this PR.

I have restructured the commits and added unit tests for encoding/decoding the DNS hostname address, as well as for parsing it. Apologies for the significant delay between receiving your review and addressing it—I’ll do my best to minimize such gaps in the future, in line with the New Development Process.

Any follow-up feedback would be very much appreciated!

PS:
It looks like the failed CI tests not related to the changes in this PR also It doesn't look like we need to add itests for this feature change, no?

ellemouton

Thanks for the PR :)

I think its a good idea to test/ensure the following:

make sure the node can handle providing its own DNS addr
make sure the node can handle receiving a DNS addr from other nodes

lnwire/dns_hostname_addr.go

server_test.go

graph/db/addr_test.go

config.go

server.go

sample-lnd.conf

ellemouton

Great work @mohamedawnallah !! 🎉

I think this is pretty much g2g! just 2 comments about commits you can drop in this PR. I'll then make a follow up PR that updates the graph SQL migration accordingly :)

graph/db/addr_test.go

lnwire/lnwire.go

discovery/chan_series.go

discovery/gossiper.go

ellemouton

Looks good!

Thanks for the fast turn around here 🙏

Leaving one more comment re a unit test. Then please also remember to add a release note entry.

Leaving my ACK in the mean time since I'll be away next week

lnwire/dns_addr.go

lightninglabs-deploy · 2025-08-29T14:07:37Z

@mohamedawnallah, remember to re-request review from reviewers when ready

yyforyongyu

One question re the test, otherwise looks good.

lnwire/writer_test.go

yyforyongyu · 2025-09-02T17:08:26Z

lnwire/dns_addr.go

+	}
+
+	if len(hostname) > 255 {
+		return fmt.Errorf("DNS hostname length %d, exceeds limit of "+


nit: think we should define errors above and return fmt.Errorf("%w: ...") here, so it's easier to be tested below, error string matching is a bit fragile.

nit: think we should define errors above and return fmt.Errorf("%w: ...") here, so it's easier to be tested below, error string matching is a bit fragile.

Addressed

cool we should return fmt.Errorf("%w: DNS hostname length %d", ...) - given the goal is to do error matching in the tests, we should also change it to require.ErrorIs instead of error string matching.

cool we should return fmt.Errorf("%w: DNS hostname length %d", ...) - given the goal is to do error matching in the tests, we should also change it to require.ErrorIs instead of error string matching.

Used wrapped errors with additional details. It seems eventually we need to match against error string i.e that part ("%w: DNS hostname length %d") since require.ErrorIs only checks if the error types match, not the exact error message content

In this commit, we remove `AddrLen` as prepration step before adding DNS address type which will have a var length. Co-authored-by: Elle Mouton <elle.mouton@gmail.com>

Co-authored-by: Elle Mouton <elle.mouton@gmail.com>

yyforyongyu

LGTM🚢 Left some nits - will merge once CI passed

lnwire/dns_addr.go

yyforyongyu · 2025-09-02T18:13:46Z

lnwire/dns_addr.go

+	}
+
+	if len(hostname) > 255 {
+		return fmt.Errorf("DNS hostname length %d, exceeds limit of "+


cool we should return fmt.Errorf("%w: DNS hostname length %d", ...) - given the goal is to do error matching in the tests, we should also change it to require.ErrorIs instead of error string matching.

lnwire/dns_addr.go

Check that the node ann doesnt contain more than 1 DNS addr. This will ensure that we now start rejecting new node announcements with multiple DNS addrs since this check is called in the gossiper before persisting a node ann to our local graph. It also validates the DNS fields according to BOLT #7 specs.

We may have already persisted node announcements that have multiple DNS addresses since we may have received them before updating our code to check for this. So here we just make sure not to send these on to our peers.

The first byte of an opaque addr must be one that we dont understand yet. We do this update in preparation for doing an on-the-fly parse of persisted opaque addrs to see if they contain addrs that we now support. For this to work, the first byte cant be 0x01 since this maps to a known address.

alexbosworth reviewed Feb 2, 2025

View reviewed changes

graph/db/addr.go Outdated Show resolved Hide resolved

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch 2 times, most recently from 3e93cdf to cb36d26 Compare February 3, 2025 13:56

MaxFangX mentioned this pull request Feb 5, 2025

[bug]: Node announcements from peers are not re-propagated if they contain a DNS hostname #9473

Closed

saubyk reviewed Feb 5, 2025

View reviewed changes

sample-lnd.conf Outdated Show resolved Hide resolved

saubyk assigned mohamedawnallah Feb 5, 2025

saubyk added this to the v0.20.0 milestone Feb 5, 2025

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch 2 times, most recently from fb721bc to 4a8adcb Compare February 5, 2025 03:06

yyforyongyu mentioned this pull request Feb 5, 2025

graph/db: correctly handle de(ser)ialisation of models.LightningNode opaque addresses #9474

Merged

ellemouton requested changes Feb 10, 2025

View reviewed changes

lnrpc/lightning.proto Outdated Show resolved Hide resolved

cmd/commands/peersrpc_active.go Show resolved Hide resolved

config.go Show resolved Hide resolved

saubyk added this to lnd v0.20 May 1, 2025

saubyk moved this to In progress in lnd v0.20 May 1, 2025

mohamedawnallah marked this pull request as draft May 2, 2025 17:32

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch 5 times, most recently from c3a6a49 to d67c686 Compare May 3, 2025 12:20

mohamedawnallah mentioned this pull request May 3, 2025

chore: remove dead code #9780

Open

9 tasks

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch 2 times, most recently from 3efa4b2 to 01c57c8 Compare May 3, 2025 15:19

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch 2 times, most recently from d48d1fd to 98d2f2f Compare May 11, 2025 17:43

mohamedawnallah marked this pull request as ready for review May 11, 2025 18:58

mohamedawnallah requested a review from ellemouton May 11, 2025 22:59

ellemouton requested changes May 12, 2025

View reviewed changes

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch 2 times, most recently from 11c8ebc to 6b38f8d Compare August 15, 2025 05:53

ellemouton reviewed Aug 15, 2025

View reviewed changes

graph/db/addr_test.go Outdated Show resolved Hide resolved

lnwire/lnwire.go Outdated Show resolved Hide resolved

discovery/chan_series.go Show resolved Hide resolved

discovery/gossiper.go Show resolved Hide resolved

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch from 6b38f8d to b4a8b24 Compare August 15, 2025 10:31

ellemouton mentioned this pull request Aug 15, 2025

graph/db: unwrap dns addresses from opaque ones during migration #10162

Merged

mohamedawnallah requested a review from ellemouton August 15, 2025 11:38

ellemouton mentioned this pull request Aug 15, 2025

multi: switch on graph SQL migration #10163

Merged

ellemouton approved these changes Aug 15, 2025

View reviewed changes

lnwire/dns_addr.go Show resolved Hide resolved

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch 2 times, most recently from 8977287 to 035fac4 Compare August 15, 2025 13:10

ellemouton requested a review from yyforyongyu September 1, 2025 06:11

yyforyongyu reviewed Sep 2, 2025

View reviewed changes

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch from 035fac4 to 84b87a5 Compare September 2, 2025 17:51

mohamedawnallah and others added 3 commits September 2, 2025 17:51

lnwire: remove AddrLen helper

7acd601

In this commit, we remove `AddrLen` as prepration step before adding DNS address type which will have a var length. Co-authored-by: Elle Mouton <elle.mouton@gmail.com>

lnwire: add DNSAddress type

a0057c2

lnwire: add encoding/decoding for DNS addr

670b26b

Co-authored-by: Elle Mouton <elle.mouton@gmail.com>

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch from 84b87a5 to 7d084ee Compare September 2, 2025 17:51

yyforyongyu approved these changes Sep 2, 2025

View reviewed changes

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch 2 times, most recently from 0ec6001 to cdf6290 Compare September 3, 2025 01:04

ellemouton and others added 5 commits September 3, 2025 01:11

graph/db+chanbackup: dns add encoding/decoding for persistence

6ef80db

docs: add release note

ad96615

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch from cdf6290 to ad96615 Compare September 3, 2025 01:11

ellemouton merged commit ea6cc81 into lightningnetwork:master Sep 3, 2025
35 of 39 checks passed

github-project-automation bot moved this from In progress to Done in lnd v0.20 Sep 3, 2025

mohamedawnallah mentioned this pull request Sep 8, 2025

[bug]: wallet creation slows sync if run before neutrino headers complete #10180

Open

[1/2] discovery+lnwire: add support for DNS host name in NodeAnnouncement msg #9455

[1/2] discovery+lnwire: add support for DNS host name in NodeAnnouncement msg #9455

Uh oh!

Conversation

mohamedawnallah commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change Description

Steps to Test

Pull Request Checklist

Testing

Code Style and Documentation

Uh oh!

coderabbitai bot commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mohamedawnallah commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mohamedawnallah commented May 11, 2025

Uh oh!

ellemouton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ellemouton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ellemouton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lightninglabs-deploy commented Aug 29, 2025

Uh oh!

yyforyongyu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yyforyongyu Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

mohamedawnallah Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

yyforyongyu Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

mohamedawnallah Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yyforyongyu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yyforyongyu Sep 2, 2025

mohamedawnallah commented Jan 29, 2025 •

edited

Loading

coderabbitai bot commented Jan 29, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

mohamedawnallah commented May 5, 2025 •

edited

Loading

mohamedawnallah Sep 3, 2025 •

edited

Loading