lntest: assert shutdown via logs only if log file handle is present #9705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Ensure shutdown assertions through log inspection are only performed when the harness node has an active log file handle. This avoids errors during shutdown when log file output is disabled.
ffranr
force-pushed
the
assert-log-shutdown-only-with-handle
branch
from
821b8b2 to
24ba098
Compare
ffranr
changed the title
yyforyongyu
reviewed
Apr 11, 2025
| hn.Name(), filename, err1) | ||
| // If the node has an open log file handle, inspect the log file | ||
| // to verify that the node shut down correctly. | ||
| if hn.logFile != nil { |
There was a problem hiding this comment.
hmm so why this would be nil? Like a customized test?
There was a problem hiding this comment.
nvm found in the commit msg
yyforyongyu
approved these changes
Apr 11, 2025
| hn.Name(), filename, err1) | ||
| // If the node has an open log file handle, inspect the log file | ||
| // to verify that the node shut down correctly. | ||
| if hn.logFile != nil { |
There was a problem hiding this comment.
nvm found in the commit msg
guggero
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Ensure shutdown assertions through log inspection are only performed when the harness node has an active log file handle. This avoids errors during shutdown when log file output is disabled.
Steps to Test
Disable log file output via CLI flag, ensure harness nodes shutdown without error.