-
Notifications
You must be signed in to change notification settings - Fork 2.2k
lncli: establish connection after parsing of mc data for loadmc #9783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lncli: establish connection after parsing of mc data for loadmc #9783
Conversation
It can take some time to unmarshal large mission control data sets such that the macaroon can expire during that phase. We postpone the connection establishment to give the user more time to answer the prompt.
This can already be done with resetmc and was only included here because loadmc was used in a different context.
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This makes the command scriptable.
714efda
to
306df70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK, LGTM 🎉
Change Description
I tested the newly added
lncli loadmc
with an even larger data set and noticed that the connection can time out because data parsing can take some time, which is why the connection is now established later. I also added askip_confirmation
flag to make the command scriptable and applied some other smaller fixes.