graph/db: introduce a V1Store interface
#9791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
3 tasks
ellemouton
force-pushed
the
graphSQL3-V1StoreInterface
branch
2 times, most recently
from
8fdf7d4 to
d195d0c
Compare
In this commit, we introduce the `V1Store` interface which the existing `graphdb.KVStore` implements today. The idea is to eventually create a SQL DB backed implementation of this interface.
Use the new `V1Store` interface as a field in the `ChannelGraph` rather than a pointer to the `KVStore` implementation in preparation for allowing a SQL implementation of `V1Store` to be used by the `ChannelGraph`. Note that two tests are adjusted in this commit to be skipped if the V1Store is not the `KVStore` implementation since the tests are very bbolt specific.
So that we can pass in the abstract V1Store in preparation for adding a SQL implementation of the KVStore.
ellemouton
force-pushed
the
graphSQL3-V1StoreInterface
branch
from
d195d0c to
30e8fe4
Compare
84 tasks
guggero
approved these changes
May 8, 2025
|
|
||
| // V1Store represents the main interface for the channel graph database for all | ||
| // channels and nodes gossiped via the V1 gossip protocol as defined in BOLT 7. | ||
| type V1Store interface { //nolint:interfacebloat |
There was a problem hiding this comment.
Yeah yeah, linter, you're not wrong. But don't judge us on this, we're working on it 😂
| }, func() {}) | ||
| require.NoError(t, err, "error reading db") | ||
| _, err = deserializeChanEdgePolicy(r) | ||
| require.ErrorIs(t, err, ErrEdgePolicyOptionalFieldNotFound) |
There was a problem hiding this comment.
Lol, so the whole kvdb.View() call was basically a no-op in the first place...
ellemouton
merged commit 55ca87b
into
lightningnetwork:elle-graph
35 of 36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we introduce the
V1Storeinterface which the existinggraphdb.KVStoreimplements today. This is in preparation for addinga SQL implementation of this interface eventually.
We then start using this interface from within the
ChannelGraphinstead of directly usinga
KVStorepointer.part of #9795