lnwire: fix test data race

[ellemouton]

Ensure that tests can run in parallel without causing a data race by adding a makeTestChannelUpdate constructor rather than sharing the same testChannelUpdate type between tests. This is needed since some tests write to the type.

Data race seen in this build.

WARNING: DATA RACE
Write at 0x0000016898[30](https://github.com/lightningnetwork/lnd/actions/runs/15775488150/job/44468893481?pr=9937#step:9:31) by goroutine 64:
  github.com/lightningnetwork/lnd/lnwire.(*ExtraOpaqueData).PackRecords()
      /home/runner/work/lnd/lnd/lnwire/extra_bytes.go:101 +0x69
  github.com/lightningnetwork/lnd/lnwire.EncodeMessageExtraData()
      /home/runner/work/lnd/lnd/lnwire/extra_bytes.go:157 +0x4d
  github.com/lightningnetwork/lnd/lnwire.(*ChannelUpdate1).Encode()
      /home/runner/work/lnd/lnd/lnwire/channel_update.go:246 +0x7af
  github.com/lightningnetwork/lnd/lnwire.TestChannelUpdateCompatibilityParsing()
      /home/runner/work/lnd/lnd/lnwire/onion_error_test.go:1[34](https://github.com/lightningnetwork/lnd/actions/runs/15775488150/job/44468893481?pr=9937#step:9:35) +0x9a
  testing.tRunner()
      /opt/hostedtoolcache/go/1.23.9/x64/src/testing/testing.go:1690 +0x226
  testing.(*T).Run.gowrap1()
      /opt/hostedtoolcache/go/1.23.9/x64/src/testing/testing.go:1743 +0x44

Previous read at 0x000001689830 by goroutine 65:
  github.com/lightningnetwork/lnd/lnwire.TestWriteOnionErrorChanUpdate()
      /home/runner/work/lnd/lnd/lnwire/onion_error_test.go:188 +0xb1
  testing.tRunner()
      /opt/hostedtoolcache/go/1.23.9/x64/src/testing/testing.go:1690 +0x226
  testing.(*T).Run.gowrap1()
      /opt/hostedtoolcache/go/1.23.9/x64/src/testing/testing.go:17[43](https://github.com/lightningnetwork/lnd/actions/runs/15775488150/job/44468893481?pr=9937#step:9:44) +0x[44](https://github.com/lightningnetwork/lnd/actions/runs/15775488150/job/44468893481?pr=9937#step:9:45)

[coderabbitai]

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

• llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[guggero]

Great catch!

[ziggie1984]

LGTM, Noice ⚡️