support url on createTarget and send lifecycle events #1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromiumoxide sends the command while connections are in progress and it doesn't cause issue w/ curl.
Collaborator
|
demo's |
karlseguin
reviewed
Oct 22, 2025
|
|
||
| const std = @import("std"); | ||
| const Page = @import("../../browser/page.zig").Page; | ||
| const timestampF = @import("../../datetime.zig").timestamp; |
Collaborator
There was a problem hiding this comment.
timestampF because it collides with existing timestamp variables?
Member
Author
There was a problem hiding this comment.
indeed, do you have a better suggestion?
Collaborator
There was a problem hiding this comment.
Nope, was just curious.
| const page = bc.session.currentPage() orelse return error.PageNotLoaded; | ||
|
|
||
| if (page.load_state == .complete) { | ||
| try sendPageLifecycle(bc, "DOMContentLoaded", timestampF()); |
Collaborator
There was a problem hiding this comment.
I like that all this is in the CDP layer!
Member
Author
|
I fixed puppeteer/playwright issues |
Member
Author
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates with #1160
urlparameter on createTarget. we now navigate oncreateTargetto dispatch events correctly, even in case ofabout:blank.