Skip to content

Commit 7a1beb0

Browse files
authored
Merge pull request #103 from lightpanda-io/fix_array_buffer_view
Fix constness for ArrayBufferview getters
2 parents e6c6ee1 + 413f5c5 commit 7a1beb0

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/binding.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -454,8 +454,12 @@ const v8::ArrayBuffer* v8__ArrayBufferView__Buffer(const v8::ArrayBufferView& se
454454
return local_to_ptr(ptr_to_local(&self)->Buffer());
455455
}
456456

457-
size_t v8__ArrayBufferView__ByteLength(v8::ArrayBufferView& self) { return self.ByteLength(); }
458-
size_t v8__ArrayBufferView__ByteOffset(v8::ArrayBufferView& self) { return self.ByteOffset(); }
457+
size_t v8__ArrayBufferView__ByteLength(const v8::ArrayBufferView& self) {
458+
return ptr_to_local(&self)->ByteLength();
459+
}
460+
size_t v8__ArrayBufferView__ByteOffset(const v8::ArrayBufferView& self) {
461+
return ptr_to_local(&self)->ByteOffset();
462+
}
459463

460464
// HandleScope
461465

src/binding.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -338,8 +338,8 @@ SharedPtr v8__ArrayBuffer__GetBackingStore(const ArrayBuffer* self);
338338

339339
// ArrayBufferView
340340
const ArrayBuffer* v8__ArrayBufferView__Buffer(const ArrayBufferView* self);
341-
size_t v8__ArrayBufferView__ByteLength(ArrayBufferView* self);
342-
size_t v8__ArrayBufferView__ByteOffset(ArrayBufferView* self);
341+
size_t v8__ArrayBufferView__ByteLength(const ArrayBufferView* self);
342+
size_t v8__ArrayBufferView__ByteOffset(const ArrayBufferView* self);
343343

344344
// HandleScope
345345
typedef struct HandleScope {

0 commit comments

Comments
 (0)