Skip to content

Fix code coverage #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged

Fix code coverage #147

merged 3 commits into from
Jul 29, 2025

Conversation

ligurio
Copy link
Owner

@ligurio ligurio commented Jul 15, 2025

No description provided.

ligurio added 3 commits July 22, 2025 18:28
Running tests is failed when CMake options `ENABLE_LAPI_TESTS` and
`ENABLE_COV` are enabled. The patch enables C/C++ flags related to
code coverage for luzer, this prevents an error on loading
luzer_impl.so due to undefined symbol `llvm_gcda_summary_info`.
- Add `LUA_SOURCE_DIR` to BuildLuaJIT.cmake, becuase it is used
  in CodeCoverage.cmake.
- Fix deprecated gcovr options: `--branches` [1] and
  `--sort-percentage` [2].

1. https://gcovr.com/en/stable/manpage.html#cmdoption-gcovr-b
2. https://gcovr.com/en/stable/manpage.html#cmdoption-gcovr-p
Build tests with enabled `ENABLE_COV` CMake option. Follows up
commit "cmake: fix code coverage with ENABLE_LAPI_TESTS".
@ligurio ligurio force-pushed the ligurio/gh-xxxx-fix-code-coverage branch from b375452 to b07e36e Compare July 22, 2025 15:30
@ligurio ligurio requested a review from Buristan July 28, 2025 13:28
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sergey!
Thanks for the patch-set!
LGTM!

@ligurio ligurio merged commit 6bc3b61 into master Jul 29, 2025
12 checks passed
@ligurio ligurio deleted the ligurio/gh-xxxx-fix-code-coverage branch July 29, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants