Closed #80 - Added authentication using rubin CIlogon. #81
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements authentication improvements by adding support for Rubin CIlogon alongside LIneA’s existing SAML2 login. Key changes include updates to Docker and compose configurations for logging and process management, modifications to SAML2 authentication handling and group management, and several templating changes for error and login pages.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docker-compose.local.yml | Added volume mount for logs to support new logging configuration. |
| compose/production/django/start & compose/local/django/start | Introduced Django compress command and adjusted autoreload settings. |
| compose/production/django/Dockerfile | Adjusted user/group creation and directory permissions for logs and data. |
| backend//templates/djangosaml2/.html | Updated various authentication pages to support Rubin CIlogon with adjusted login and error URLs. |
| backend/sky_viewer/common/saml2*.py | Modified authentication flow and identifier extraction for SAML2 integration. |
| backend/config/settings/* & .envs/.local/.django | Updated settings for logging, sessions, and login URLs. |
| backend/config/urls.py | Revised logout view and added an API login route. |
Comments suppressed due to low confidence (5)
backend/sky_viewer/templates/djangosaml2/waiting_aproval.html:150
- The URL scheme 'malito:' appears to be a typo; it should be 'mailto:'.
If you have any other problem, please <a href="malito:helpdesk@linea.org.br" target="_blank">contact our helpdesk</a>.
backend/sky_viewer/templates/djangosaml2/waiting_aproval.html:1
- The filename 'waiting_aproval.html' appears to be misspelled; consider renaming it to 'waiting_approval.html' for clarity.
waiting_aproval.html
backend/sky_viewer/templates/djangosaml2/login_error.html:156
- The URL 'malito:helpdesk@linea.org.br' is likely a typo; it should be 'mailto:helpdesk@linea.org.br'.
<a href="malito:helpdesk@linea.org.br" target="_blank">contact our helpdesk</a>
backend/sky_viewer/templates/djangosaml2/rubin_need_registration.html:151
- Correct the URL scheme from 'malito:' to 'mailto:' in the helpdesk link.
<a href="malito:helpdesk@linea.org.br" target="_blank">contact our helpdesk</a>
backend/sky_viewer/templates/djangosaml2/linea_need_registration.html:151
- The URL 'malito:' should be corrected to 'mailto:' in the helpdesk link.
<a href="malito:helpdesk@linea.org.br" target="_blank">contact our helpdesk</a>
No description provided.