-
-
Notifications
You must be signed in to change notification settings - Fork 52
feat(storybook): upgrade to Storybook 9 ✨ #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for storybook-addon-mock ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the project to Storybook 9 with the necessary changes for module import paths, dependency versions, and CI workflows. The key changes include:
- Updating import paths for Storybook modules across the mock addon and docs packages.
- Adjusting dependency and peer dependency versions, including updating Storybook and React support.
- Replacing the old CI workflow with a new build validation workflow.
Reviewed Changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/mock-addon/src/withRoundTrip.js | Updated internal Storybook module import paths. |
packages/mock-addon/src/preset/manager.js | Updated internal Storybook module import paths. |
packages/mock-addon/src/components/MockItem/index.js | Updated theming and control component import paths as per migration. |
packages/mock-addon/src/components/ErrorItem/index.js | Updated theming import path. |
packages/mock-addon/src/components/Card/index.js | Updated theming import path. |
packages/mock-addon/src/components/ButtonToggle/index.js | Updated theming import path. |
packages/mock-addon/src/Panel.js | Updated Storybook API and component import paths. |
packages/mock-addon/package.json | Updated Storybook versions and peer dependency ranges. |
packages/mock-addon-docs/stories/docs/*.mdx | Updated MDX files to use the new addon-docs/blocks import. |
packages/mock-addon-docs/package.json | Upgraded Storybook-related dependencies and added remark-gfm. |
packages/mock-addon-docs/.storybook/main.js | Added absolute path resolution for preset import and remark-gfm config. |
.nvmrc | Updated Node LTS version to lts/jod. |
.github/workflows/nodejs.yml | Removed outdated CI workflow. |
.github/workflows/build.yml | Added new CI workflow for build validation and code style checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JamesIves for looking into this upgrade!
Makes the necessary adjustments for migration to Storybook 9. This is a breaking change, and should likely be a major version due to the peer dependency changes.
lts/jod
is now used.remark-gfm
as the tables in the doc site were broken.Closes #228 #226