Update to wgpu 25 #908
Update to wgpu 25 #908
Conversation
|
This will need Wumpf/wgpu-profiler#95 |
|
Also, before this lands, we'll need to do a release of Vello that uses wgpu 24 to keep |
sparse_strips/vello_hybrid/examples/winit/src/render_context.rs
Outdated
Show resolved
Hide resolved
waywardmonkeys
force-pushed
the
update-wgpu-25
branch
from
a84f9ec to
2979152
Compare
waywardmonkeys
force-pushed
the
update-wgpu-25
branch
from
2979152 to
a65ce98
Compare
Cargo.toml
Outdated
| @@ -112,7 +112,7 @@ vello_hybrid = { path = "sparse_strips/vello_hybrid" } | |||
| vello_hybrid_scenes = { path = "sparse_strips/vello_hybrid/examples/scenes" } | |||
|
|
|||
| # NOTE: Make sure to keep this in sync with the version badge in README.md and vello/README.md | |||
| wgpu = { version = "24.0.1" } | |||
| wgpu = { version = "25.0.0" } | |||
There was a problem hiding this comment.
Thoughts: We could make this default-features=false. That makes some things complicated, and some things better.
Probably not for this PR
waywardmonkeys
force-pushed
the
update-wgpu-25
branch
2 times, most recently
from
54a9cef to
fdac86c
Compare
|
any progress with this? |
waywardmonkeys
force-pushed
the
update-wgpu-25
branch
from
fdac86c to
bd0d080
Compare
wgpu 25 adjusted the downlevel limits so directly setting `max_color_attachments` to 4 is no longer necessary (gfx-rs/wgpu#6994). wgpu 25 also now does polyfills for `unpack4x8unorm` and friends thanks to @DJMcNab in gfx-rs/wgpu#7408.
waywardmonkeys
force-pushed
the
update-wgpu-25
branch
from
bd0d080 to
18da0c7
Compare
Sounds like a good follow up for someone that isn't me! |
|
Okay. I'd like to land this. Bevy 0.17 is coming up and while it is currently on wgpu 25, they're probably going to update to the newly released wgpu 26 before releasing 0.17. I don't see us publishing a new Vello in the next couple of weeks, so let's just roll this through. |
In servo I observed performance regression with #908: https://xi.zulipchat.com/#narrow/channel/197075-vello/topic/Servo.202D.20canvas.20backend/with/528398019 but disabling shader runtime checks gives it back on pre #908. --------- Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
wgpu 25 adjusted the downlevel limits so directly
setting
max_color_attachmentsto 4 is no longer necessary (gfx-rs/wgpu#6994).wgpu 25 also now does polyfills for
unpack4x8unormand friends thanks to @DJMcNab in gfx-rs/wgpu#7408.