Replace sneakythrows

Author: Chris Li

cdi-core/src/main/java/com/linkedin/cdi/converter/AvroNormalizerConverter.java

@@ -7,6 +7,8 @@
 import com.google.common.base.Optional;
 import com.google.gson.JsonArray;
 import com.google.gson.JsonElement;
+import com.linkedin.cdi.configuration.MultistageProperties;
+import com.linkedin.cdi.util.AvroSchemaUtils;
 import java.util.ArrayList;
 import java.util.HashSet;
 import java.util.List;
@@ -18,9 +20,6 @@
 import org.apache.gobblin.converter.Converter;
 import org.apache.gobblin.converter.SchemaConversionException;
 import org.apache.gobblin.converter.SingleRecordIterable;
-import org.apache.gobblin.converter.avro.UnsupportedDateTypeException;
-import com.linkedin.cdi.configuration.MultistageProperties;
-import com.linkedin.cdi.util.AvroSchemaUtils;
 import org.apache.gobblin.util.AvroUtils;
 import org.apache.gobblin.util.EmptyIterable;
 
@@ -92,11 +91,7 @@ public Schema convertSchema(Schema schema, WorkUnitState workUnitState) throws S
       buildIntermediateSchemas(schema);
     }
 
-    try {
-      finalSchema = AvroSchemaUtils.fromJsonSchema(targetSchema, workUnitState);
-    } catch (UnsupportedDateTypeException e) {
-      throw new SchemaConversionException(e);
-    }
+    finalSchema = AvroSchemaUtils.fromJsonSchema(targetSchema, workUnitState);
     return finalSchema;
   }
 

cdi-core/src/main/java/com/linkedin/cdi/filter/AvroSchemaBasedFilter.java

@@ -12,7 +12,6 @@
 import org.apache.avro.generic.GenericData;
 import org.apache.avro.generic.GenericRecord;
 import org.apache.gobblin.configuration.WorkUnitState;
-import org.apache.gobblin.converter.avro.UnsupportedDateTypeException;
 import org.apache.gobblin.util.AvroUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -30,7 +29,7 @@ public AvroSchemaBasedFilter(JsonIntermediateSchema schema, AvroExtractorKeys av
   }
 
   @Override
-  public GenericRecord filter(GenericRecord input) throws UnsupportedDateTypeException {
+  public GenericRecord filter(GenericRecord input) {
     Schema outputSchema = AvroSchemaUtils.fromJsonSchema(schema.toJson(), state);
     GenericRecord filteredRow = new GenericData.Record(outputSchema);
     for (String fieldName : AvroSchemaUtils.getSchemaFieldNames(outputSchema)) {

cdi-core/src/main/java/com/linkedin/cdi/filter/MultistageSchemaBasedFilter.java

@@ -5,7 +5,6 @@
 package com.linkedin.cdi.filter;
 
 import com.linkedin.cdi.util.JsonIntermediateSchema;
-import org.apache.gobblin.converter.avro.UnsupportedDateTypeException;
 
 
 /**
@@ -21,7 +20,7 @@ public MultistageSchemaBasedFilter(JsonIntermediateSchema schema) {
   }
 
   @Override
-  public T filter(T input) throws UnsupportedDateTypeException {
+  public T filter(T input) {
     return null;
   }
 }

cdi-core/src/main/java/com/linkedin/cdi/filter/SchemaBasedFilter.java

@@ -4,13 +4,10 @@
 
 package com.linkedin.cdi.filter;
 
-import org.apache.gobblin.converter.avro.UnsupportedDateTypeException;
-
-
 /**
  * Base filter interface
  *
  */
 public interface SchemaBasedFilter<T> {
-  T filter(T input) throws UnsupportedDateTypeException;
+  T filter(T input);
 }

cdi-core/src/main/java/com/linkedin/cdi/util/AvroSchemaUtils.java

@@ -24,12 +24,16 @@ public interface AvroSchemaUtils {
    * @return avro schema
    * @throws UnsupportedDateTypeException unsupported type
    */
-  static Schema fromJsonSchema(JsonArray schema, WorkUnitState state) throws UnsupportedDateTypeException {
+  static Schema fromJsonSchema(JsonArray schema, WorkUnitState state) {
     JsonSchema jsonSchema = new JsonSchema(schema);
     jsonSchema.setColumnName(state.getExtract().getTable());
-    JsonElementConversionFactory.RecordConverter recordConverter =
-        new JsonElementConversionFactory.RecordConverter(jsonSchema, state, state.getExtract().getNamespace());
-    return recordConverter.schema();
+    try {
+      JsonElementConversionFactory.RecordConverter recordConverter =
+          new JsonElementConversionFactory.RecordConverter(jsonSchema, state, state.getExtract().getNamespace());
+      return recordConverter.schema();
+    } catch (Exception e) {
+      throw new RuntimeException(e.getMessage(), e);
+    }
   }
 
   /**
@@ -62,12 +66,7 @@ static GenericRecord createEOF(WorkUnitState state) {
     JsonArray eofSchema = new Gson()
         .fromJson("[{\"columnName\":\"EOF\",\"isNullable\":\"false\",\"dataType\":{\"type\":\"string\"}}]",
             JsonArray.class);
-    Schema schema = null;
-    try {
-      schema = fromJsonSchema(eofSchema, state);
-    } catch (UnsupportedDateTypeException e) {
-      // impossible, since the schema is fixed here and string type is supported
-    }
+    Schema schema = fromJsonSchema(eofSchema, state);
     assert (schema != null);
     GenericRecord eofRecord = new GenericData.Record(schema);
     eofRecord.put("EOF", "EOF");