Skip to content

Conversation

@nicholsn
Copy link

In python 3.13, typing.re was removed (deprecated since Python 3.8). See python/cpython#92871

This pr refactors to support python 3.13 which currently throws

ImportError: cannot import name 're' from 'typing' 

In python 3.13, `typing.re` was removed (deprecated since Python 3.8). See python/cpython#92871

This pr refactors to support python 3.13 which currently throws

```python
ImportError: cannot import name 're' from 'typing' 
```
@nicholsn
Copy link
Author

Ok, I think that last commit should work - @sierra-moxon can you trigger the CI?

@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.59%. Comparing base (1b5e9f7) to head (c28679a).
Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (1b5e9f7) and HEAD (c28679a). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (1b5e9f7) HEAD (c28679a)
7 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #353       +/-   ##
==========================================
- Coverage   63.43%   4.59%   -58.84%     
==========================================
  Files          63      60        -3     
  Lines        8982    8088      -894     
  Branches     2574    2147      -427     
==========================================
- Hits         5698     372     -5326     
- Misses       2665    7716     +5051     
+ Partials      619       0      -619     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalito
Copy link
Member

dalito commented Mar 27, 2025

The big Python 3.13 PR #345 was just merged. This PR is probably no longer needed. @nicholsn can you check?

@nicholsn
Copy link
Author

Ya I realized this was way more involved once I dug in. I'll close the PR

@nicholsn nicholsn closed this Mar 27, 2025
@nicholsn nicholsn deleted the patch-1 branch March 27, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants