Convert test_loaders.py to pytest format #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vladistan
commented
Aug 1, 2025
vladistan
commented
- Convert setUpClass to pytest module-scoped fixture
- Convert 6 test methods to standalone functions
- Convert unittest.skipIf to pytest.mark.skip
- Convert unittest.SkipTest to pytest.skip
- Reuse loader_test helper function from test_loaders_pydantic
- Preserve RDF loader functionality and context server setup
vladistan
force-pushed
the
convert-test-loaders-to-pytest
branch
2 times, most recently
from
7bc1cd3 to
294c116
Compare
|
Apart from fixing the test failures, does this need extra work before being moved out of draft status? |
vladistan
force-pushed
the
convert-test-loaders-to-pytest
branch
3 times, most recently
from
4bd0297 to
034cc89
Compare
vladistan
force-pushed
the
convert-test-loaders-to-pytest
branch
3 times, most recently
from
ad11a9f to
24ec1db
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
=======================================
Coverage 77.38% 77.38%
=======================================
Files 52 52
Lines 4479 4479
Branches 979 979
=======================================
Hits 3466 3466
Misses 785 785
Partials 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vladistan
force-pushed
the
convert-test-loaders-to-pytest
branch
from
24ec1db to
6cb5edd
Compare
- Convert setUpClass to pytest module-scoped fixture - Convert 6 test methods to standalone functions - Convert unittest.skipIf to pytest.mark.skip - Convert unittest.SkipTest to pytest.skip - Reuse loader_test helper function from test_loaders_pydantic - Preserve RDF loader functionality and context server setup
vladistan
force-pushed
the
convert-test-loaders-to-pytest
branch
from
6cb5edd to
8dc1ea1
Compare
sierra-moxon
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.