Convert test_loaders_pydantic.py to pytest format #446
Conversation
vladistan
commented
Aug 2, 2025
vladistan
commented
- Extract loader_test helper function from base class
- Convert 4 test methods to standalone functions
- Test both YAML and JSON loaders with different models
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 77.38% 77.38%
=======================================
Files 52 52
Lines 4479 4479
Branches 979 979
=======================================
Hits 3466 3466
Misses 785 785
Partials 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vladistan
force-pushed
the
convert-test-loaders-pydantic-to-pytest
branch
from
4150589 to
87c9f70
Compare
vladistan
force-pushed
the
convert-test-loaders-pydantic-to-pytest
branch
from
87c9f70 to
c1c94ae
Compare
vladistan
force-pushed
the
convert-test-loaders-pydantic-to-pytest
branch
from
bb35ddc to
96d34dc
Compare
|
weird... works on my machine :-( |
vladistan
force-pushed
the
convert-test-loaders-pydantic-to-pytest
branch
from
e96c670 to
4089c9f
Compare
|
The issue here is that there is a test somewhere that's creating the files that these tests are using for comparison (the files already exist if you've run the tests locally, which is why it's so hard to debug locally). Files need to be added to the repo for these comparisons to execute correctly. The potentially bigger problem is that some directories are being git-ignored and this problem may affect numerous files in the repo. |
vladistan
force-pushed
the
convert-test-loaders-pydantic-to-pytest
branch
from
929b645 to
af32ced
Compare
vladistan
force-pushed
the
convert-test-loaders-pydantic-to-pytest
branch
from
af32ced to
2ae80c2
Compare
- Extract loader_test helper function from base class - Convert 4 test methods to standalone functions - Test both YAML and JSON loaders with different models
vladistan
force-pushed
the
convert-test-loaders-pydantic-to-pytest
branch
2 times, most recently
from
219b8d6 to
c694b9c
Compare
|
Ahh ... thanks for digging it up. So looks like we are indeed reading other tests outputs, I don't think it's a right thing to do. I copied those outputs into the input directory they are rather short. I think original test was working because it was importing things from other test files which is also not right thing to do. I am going to clean it up and get ready for merging. |
vladistan
force-pushed
the
convert-test-loaders-pydantic-to-pytest
branch
from
c694b9c to
f2ddd0e
Compare
Explicitly add input files for test cases do not read test inputs from output directory
vladistan
force-pushed
the
convert-test-loaders-pydantic-to-pytest
branch
from
f2ddd0e to
883e590
Compare
|
Ok now all tests are passing |
| @@ -0,0 +1,20 @@ | |||
| id: S001 | |||
There was a problem hiding this comment.
This is identical to the other file -- I would just have a single file, book_series_lotr.yaml.
| @@ -0,0 +1,41 @@ | |||
| persons: | |||
There was a problem hiding this comment.
it looks like this is also identical to the yaml version -- just add one, no need for duplicates.
3 participants
