test_schemaview.py - explode tests III #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## schemaview_explode_tests_II #462 +/- ##
============================================================
Coverage 77.37% 77.37%
============================================================
Files 52 52
Lines 4478 4478
Branches 979 979
============================================================
Hits 3465 3465
Misses 785 785
Partials 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ialarmedalien
force-pushed
the
schemaview_explode_tests_III
branch
from
ef4df60 to
bb52d7a
Compare
ialarmedalien
changed the base branch from
main
to
schemaview_explode_tests_II
ialarmedalien
changed the base branch from
schemaview_explode_tests_II
to
main
ialarmedalien
changed the base branch from
main
to
schemaview_explode_tests_II
ialarmedalien
force-pushed
the
schemaview_explode_tests_III
branch
from
bb52d7a to
7f96c8f
Compare
ialarmedalien
commented
Oct 2, 2025
Comment on lines
+422
to
+423
| assert set(view.all_classes()) == set(view2.all_classes()) | ||
| assert set(view.all_classes(imports=False)) == set(view2.all_classes(imports=False)) |
There was a problem hiding this comment.
test content, not just length
ialarmedalien
commented
Oct 2, 2025
| assert set(view.class_descendants(THING)) == {THING, PERSON, "Organization", COMPANY, ADULT} | ||
|
|
||
|
|
||
| def test_class_slots(schema_view_no_imports: SchemaView) -> None: |
There was a problem hiding this comment.
moved up to be with the all_classes / class_induced_slots tests
ialarmedalien
commented
Oct 2, 2025
Comment on lines
-1572
to
-1574
| def test_induced_slot_yet_again(schema_view_with_imports: SchemaView) -> None: | ||
| """Test induced slots yet again - no such thing as too many induced_slot tests, right?""" | ||
| view = schema_view_with_imports |
There was a problem hiding this comment.
all these already existed in the induced_slot tests that we already had
kevinschaper
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More breakup of long schemaview test methods.
schemaview_explode_tests_II should be merged first as this branch is based on that one.
It's much easier to view this branch one commit at a time; the first commit breaks up the long
test_importstest into smaller chunks, and the second commit moves those chunks to different parts of the file.This PR also identified some repeated lines, which have been removed.