Removed stale fields and updated unit tests

Author: ezilber-akamai

linode_api4/objects/database.py

@@ -155,21 +155,17 @@ class MySQLDatabaseConfigMySQLOptions(JSONObject):
     innodb_lock_wait_timeout: Optional[int] = None
     innodb_log_buffer_size: Optional[int] = None
     innodb_online_alter_log_max_size: Optional[int] = None
-    innodb_print_all_deadlocks: Optional[bool] = None
     innodb_read_io_threads: Optional[int] = None
     innodb_rollback_on_timeout: Optional[bool] = None
     innodb_thread_concurrency: Optional[int] = None
     innodb_write_io_threads: Optional[int] = None
     interactive_timeout: Optional[int] = None
     internal_tmp_mem_storage_engine: Optional[str] = None
-    log_output: Optional[str] = None
-    long_query_time: Optional[float] = None
     max_allowed_packet: Optional[int] = None
     max_heap_table_size: Optional[int] = None
     net_buffer_length: Optional[int] = None
     net_read_timeout: Optional[int] = None
     net_write_timeout: Optional[int] = None
-    slow_query_log: Optional[bool] = None
     sort_buffer_size: Optional[int] = None
     sql_mode: Optional[str] = None
     sql_require_primary_key: Optional[bool] = None
@@ -186,7 +182,6 @@ class MySQLDatabaseConfigOptions(JSONObject):
 
     mysql: Optional[MySQLDatabaseConfigMySQLOptions] = None
     binlog_retention_period: Optional[int] = None
-    service_log: Optional[bool] = None
 
 
 @dataclass
@@ -208,7 +203,6 @@ class PostgreSQLDatabaseConfigPGOptions(JSONObject):
 
     autovacuum_analyze_scale_factor: Optional[float] = None
     autovacuum_analyze_threshold: Optional[int] = None
-    autovacuum_freeze_max_age: Optional[int] = None
     autovacuum_max_workers: Optional[int] = None
     autovacuum_naptime: Optional[int] = None
     autovacuum_vacuum_cost_delay: Optional[int] = None
@@ -223,18 +217,12 @@ class PostgreSQLDatabaseConfigPGOptions(JSONObject):
     default_toast_compression: Optional[str] = None
     idle_in_transaction_session_timeout: Optional[int] = None
     jit: Optional[bool] = None
-    log_autovacuum_min_duration: Optional[int] = None
-    log_error_verbosity: Optional[str] = None
-    log_line_prefix: Optional[str] = None
-    log_min_duration_statement: Optional[int] = None
-    log_temp_files: Optional[int] = None
     max_files_per_process: Optional[int] = None
     max_locks_per_transaction: Optional[int] = None
     max_logical_replication_workers: Optional[int] = None
     max_parallel_workers: Optional[int] = None
     max_parallel_workers_per_gather: Optional[int] = None
     max_pred_locks_per_transaction: Optional[int] = None
-    max_prepared_transactions: Optional[int] = None
     max_replication_slots: Optional[int] = None
     max_slot_wal_keep_size: Optional[int] = None
     max_stack_depth: Optional[int] = None
@@ -268,9 +256,7 @@ class PostgreSQLDatabaseConfigOptions(JSONObject):
     pg: Optional[PostgreSQLDatabaseConfigPGOptions] = None
     pg_stat_monitor_enable: Optional[bool] = None
     pglookout: Optional[PostgreSQLDatabaseConfigPGLookoutOptions] = None
-    service_log: Optional[bool] = None
     shared_buffers_percentage: Optional[float] = None
-    synchronous_replication: Optional[str] = None
     work_mem: Optional[int] = None
 
 

test/fixtures/databases_mysql_config.json

@@ -92,12 +92,6 @@
       "requires_restart": false,
       "type": "integer"
     },
-    "innodb_print_all_deadlocks": {
-      "description": "When enabled, information about all deadlocks in InnoDB user transactions is recorded in the error log. Disabled by default.",
-      "example": true,
-      "requires_restart": false,
-      "type": "boolean"
-    },
     "innodb_read_io_threads": {
       "description": "The number of I/O threads for read operations in InnoDB. Default is 4. Changing this parameter will lead to a restart of the MySQL service.",
       "example": 10,
@@ -146,26 +140,6 @@
       "requires_restart": false,
       "type": "string"
     },
-    "log_output": {
-      "description": "The slow log output destination when slow_query_log is ON. To enable MySQL AI Insights, choose INSIGHTS. To use MySQL AI Insights and the mysql.slow_log table at the same time, choose INSIGHTS,TABLE. To only use the mysql.slow_log table, choose TABLE. To silence slow logs, choose NONE.",
-      "enum": [
-        "INSIGHTS",
-        "NONE",
-        "TABLE",
-        "INSIGHTS,TABLE"
-      ],
-      "example": "INSIGHTS",
-      "requires_restart": false,
-      "type": "string"
-    },
-    "long_query_time": {
-      "description": "The slow_query_logs work as SQL statements that take more than long_query_time seconds to execute.",
-      "example": 10,
-      "maximum": 3600,
-      "minimum": 0.0,
-      "requires_restart": false,
-      "type": "number"
-    },
     "max_allowed_packet": {
       "description": "Size of the largest message in bytes that can be received by the server. Default is 67108864 (64M)",
       "example": 67108864,
@@ -206,12 +180,6 @@
       "requires_restart": false,
       "type": "integer"
     },
-    "slow_query_log": {
-      "description": "Slow query log enables capturing of slow queries. Setting slow_query_log to false also truncates the mysql.slow_log table.",
-      "example": true,
-      "requires_restart": false,
-      "type": "boolean"
-    },
     "sort_buffer_size": {
       "description": "Sort buffer size in bytes for ORDER BY optimization. Default is 262144 (256K)",
       "example": 262144,
@@ -258,14 +226,5 @@
     "minimum": 600,
     "requires_restart": false,
     "type": "integer"
-  },
-  "service_log": {
-    "description": "Store logs for the service so that they are available in the HTTP API and console.",
-    "example": true,
-    "requires_restart": false,
-    "type": [
-      "boolean",
-      "null"
-    ]
   }
 }

test/fixtures/databases_mysql_instances.json

@@ -32,7 +32,6 @@
       "version": "8.0.26",
       "engine_config": {
         "binlog_retention_period": 600,
-        "service_log": true,
         "mysql": {
           "connect_timeout": 10,
           "default_time_zone": "+03:00",
@@ -45,21 +44,17 @@
           "innodb_lock_wait_timeout": 50,
           "innodb_log_buffer_size": 16777216,
           "innodb_online_alter_log_max_size": 134217728,
-          "innodb_print_all_deadlocks": true,
           "innodb_read_io_threads": 10,
           "innodb_rollback_on_timeout": true,
           "innodb_thread_concurrency": 10,
           "innodb_write_io_threads": 10,
           "interactive_timeout": 3600,
           "internal_tmp_mem_storage_engine": "TempTable",
-          "log_output": "INSIGHTS",
-          "long_query_time": 10,
           "max_allowed_packet": 67108864,
           "max_heap_table_size": 16777216,
           "net_buffer_length": 16384,
           "net_read_timeout": 30,
           "net_write_timeout": 30,
-          "slow_query_log": true,
           "sort_buffer_size": 262144,
           "sql_mode": "ANSI,TRADITIONAL",
           "sql_require_primary_key": true,

test/fixtures/databases_postgresql_config.json

@@ -14,14 +14,6 @@
       "requires_restart": false,
       "type": "integer"
     },
-    "autovacuum_freeze_max_age": {
-      "description": "Specifies the maximum age (in transactions) that a table's pg_class.relfrozenxid field can attain before a VACUUM operation is forced to prevent transaction ID wraparound within the table. Note that the system will launch autovacuum processes to prevent wraparound even when autovacuum is otherwise disabled. This parameter will cause the server to be restarted.",
-      "example": 200000000,
-      "maximum": 1500000000,
-      "minimum": 200000000,
-      "requires_restart": true,
-      "type": "integer"
-    },
     "autovacuum_max_workers": {
       "description": "Specifies the maximum number of autovacuum processes (other than the autovacuum launcher) that may be running at any one time. The default is three. This parameter can only be set at server start.",
       "maximum": 20,
@@ -127,48 +119,6 @@
       "requires_restart": false,
       "type": "boolean"
     },
-    "log_autovacuum_min_duration": {
-      "description": "Causes each action executed by autovacuum to be logged if it ran for at least the specified number of milliseconds. Setting this to zero logs all autovacuum actions. Minus-one (the default) disables logging autovacuum actions.",
-      "maximum": 2147483647,
-      "minimum": -1,
-      "requires_restart": false,
-      "type": "integer"
-    },
-    "log_error_verbosity": {
-      "description": "Controls the amount of detail written in the server log for each message that is logged.",
-      "enum": [
-        "TERSE",
-        "DEFAULT",
-        "VERBOSE"
-      ],
-      "requires_restart": false,
-      "type": "string"
-    },
-    "log_line_prefix": {
-      "description": "Choose from one of the available log formats.",
-      "enum": [
-        "'pid=%p,user=%u,db=%d,app=%a,client=%h '",
-        "'pid=%p,user=%u,db=%d,app=%a,client=%h,txid=%x,qid=%Q '",
-        "'%t [%p]: [%l-1] user=%u,db=%d,app=%a,client=%h '",
-        "'%m [%p] %q[user=%u,db=%d,app=%a] '"
-      ],
-      "requires_restart": false,
-      "type": "string"
-    },
-    "log_min_duration_statement": {
-      "description": "Log statements that take more than this number of milliseconds to run, -1 disables",
-      "maximum": 86400000,
-      "minimum": -1,
-      "requires_restart": false,
-      "type": "integer"
-    },
-    "log_temp_files": {
-      "description": "Log statements for each temporary file created larger than this number of kilobytes, -1 disables",
-      "maximum": 2147483647,
-      "minimum": -1,
-      "requires_restart": false,
-      "type": "integer"
-    },
     "max_files_per_process": {
       "description": "PostgreSQL maximum number of files that can be open per process",
       "maximum": 4096,
@@ -211,13 +161,6 @@
       "requires_restart": false,
       "type": "integer"
     },
-    "max_prepared_transactions": {
-      "description": "PostgreSQL maximum prepared transactions",
-      "maximum": 10000,
-      "minimum": 0,
-      "requires_restart": false,
-      "type": "integer"
-    },
     "max_replication_slots": {
       "description": "PostgreSQL maximum replication slots",
       "maximum": 64,
@@ -405,15 +348,6 @@
       "type": "integer"
     }
   },
-  "service_log": {
-    "description": "Store logs for the service so that they are available in the HTTP API and console.",
-    "example": true,
-    "requires_restart": false,
-    "type": [
-      "boolean",
-      "null"
-    ]
-  },
   "shared_buffers_percentage": {
     "description": "Percentage of total RAM that the database server uses for shared memory buffers. Valid range is 20-60 (float), which corresponds to 20% - 60%. This setting adjusts the shared_buffers configuration value.",
     "example": 41.5,
@@ -422,16 +356,6 @@
     "requires_restart": false,
     "type": "number"
   },
-  "synchronous_replication": {
-    "description": "Synchronous replication type. Note that the service plan also needs to support synchronous replication.",
-    "enum": [
-      "quorum",
-      "off"
-    ],
-    "example": "off",
-    "requires_restart": false,
-    "type": "string"
-  },
   "work_mem": {
     "description": "Sets the maximum amount of memory to be used by a query operation (such as a sort or hash table) before writing to temporary disk files, in MB. Default is 1MB + 0.075% of total RAM (up to 32MB).",
     "example": 4,

test/fixtures/databases_postgresql_instances.json

@@ -35,7 +35,6 @@
         "pg": {
           "autovacuum_analyze_scale_factor": 0.5,
           "autovacuum_analyze_threshold": 100,
-          "autovacuum_freeze_max_age": 400000000,
           "autovacuum_max_workers": 10,
           "autovacuum_naptime": 100,
           "autovacuum_vacuum_cost_delay": 50,
@@ -50,18 +49,12 @@
           "default_toast_compression": "lz4",
           "idle_in_transaction_session_timeout": 100,
           "jit": true,
-          "log_autovacuum_min_duration": 100,
-          "log_error_verbosity": "DEFAULT",
-          "log_line_prefix": "'pid=%p,user=%u,db=%d,app=%a,client=%h '",
-          "log_min_duration_statement": 100,
-          "log_temp_files": 100,
           "max_files_per_process": 100,
           "max_locks_per_transaction": 100,
           "max_logical_replication_workers": 32,
           "max_parallel_workers": 64,
           "max_parallel_workers_per_gather": 64,
           "max_pred_locks_per_transaction": 1000,
-          "max_prepared_transactions": 5000,
           "max_replication_slots": 32,
           "max_slot_wal_keep_size": 100,
           "max_stack_depth": 3507152,
@@ -88,9 +81,7 @@
         "pglookout": {
           "max_failover_replication_time_lag": 1000
         },
-        "service_log": false,
         "shared_buffers_percentage": 41.5,
-        "synchronous_replication": "off",
         "work_mem": 4
       }
     }