Interface upgrade test

Author: lgarber-akamai

linode_api4/objects/linode.py

@@ -1996,7 +1996,7 @@ def interfaces(self) -> List[LinodeInterface]:
 
     def upgrade_interfaces(
         self,
-        config: Union[Config, int],
+        config: Optional[Union[Config, int]] = None,
         dry_run: bool = False,
     ) -> UpgradeInterfacesResult:
         """

test/integration/conftest.py

@@ -432,6 +432,28 @@ def create_vpc_with_subnet_and_linode(
     instance.delete()
 
 
+@pytest.fixture(scope="session")
+def create_vpc_with_subnet_and_linode_offline(
+    test_linode_client, create_vpc_with_subnet, e2e_test_firewall
+):
+    vpc, subnet = create_vpc_with_subnet
+
+    label = get_test_label(length=8)
+
+    instance, password = test_linode_client.linode.instance_create(
+        "g6-standard-1",
+        vpc.region,
+        booted=False,
+        image="linode/debian11",
+        label=label,
+        firewall=e2e_test_firewall,
+    )
+
+    yield vpc, subnet, instance, password
+
+    instance.delete()
+
+
 @pytest.fixture(scope="session")
 def create_multiple_vpcs(test_linode_client):
     client = test_linode_client

test/integration/models/linode/test_linode.py

@@ -9,6 +9,7 @@
 
 import pytest
 
+from linode_api4 import LinodeInterface
 from linode_api4.errors import ApiError
 from linode_api4.objects import (
     Config,
@@ -588,6 +589,102 @@ def test_linode_initate_migration(test_linode_client, e2e_test_firewall):
     assert res
 
 
+def test_linode_upgrade_interfaces(
+    linode_for_network_interface_tests,
+    create_vpc_with_subnet_and_linode_offline,
+):
+    vpc, subnet, linode, _ = create_vpc_with_subnet_and_linode_offline
+    config = linode.configs[0]
+
+    new_interfaces = [
+        {"purpose": "public"},
+        ConfigInterface(
+            purpose="vlan", label="cool-vlan", ipam_address="10.0.0.4/32"
+        ),
+        ConfigInterface(
+            purpose="vpc",
+            subnet_id=subnet.id,
+            primary=True,
+            ipv4=ConfigInterfaceIPv4(vpc="10.0.0.2", nat_1_1="any"),
+            ip_ranges=["10.0.0.5/32"],
+        ),
+    ]
+    config.interfaces = new_interfaces
+
+    config.save()
+
+    def __assert_base(iface: LinodeInterface):
+        assert iface.id is not None
+        assert iface.created is not None
+        assert iface.updated is not None
+        assert iface.version is not None
+
+        assert len(iface.mac_address) > 0
+
+    def __assert_public(iface: LinodeInterface):
+        __assert_base(iface)
+
+        assert not iface.default_route.ipv4
+        assert iface.default_route.ipv6
+
+        assert len(iface.public.ipv4.addresses) == 0
+        assert len(iface.public.ipv4.shared) == 0
+
+        assert len(iface.public.ipv6.slaac) == 1
+        assert iface.public.ipv6.slaac[0].address == linode.ipv6.split("/")[0]
+
+        assert len(iface.public.ipv6.ranges) == 0
+        assert len(iface.public.ipv6.shared) == 0
+
+    def __assert_vpc(iface: LinodeInterface):
+        __assert_base(iface)
+
+        assert iface.default_route.ipv4
+        assert not iface.default_route.ipv6
+
+        assert iface.vpc.vpc_id == vpc.id
+        assert iface.vpc.subnet_id == subnet.id
+
+        assert len(iface.vpc.ipv4.addresses) == 1
+        assert iface.vpc.ipv4.addresses[0].address == "10.0.0.2"
+        assert iface.vpc.ipv4.addresses[0].primary
+        assert iface.vpc.ipv4.addresses[0].nat_1_1_address is not None
+
+        assert len(iface.vpc.ipv4.ranges) == 1
+        assert iface.vpc.ipv4.ranges[0].range == "10.0.0.5/32"
+
+    def __assert_vlan(iface: LinodeInterface):
+        __assert_base(iface)
+
+        assert not iface.default_route.ipv4
+        assert not iface.default_route.ipv6
+
+        assert iface.vlan.vlan_label == "cool-vlan"
+        assert iface.vlan.ipam_address == "10.0.0.4/32"
+
+    result = linode.upgrade_interfaces(dry_run=True)
+
+    assert result.dry_run
+    assert result.config_id == config.id
+
+    __assert_public(result.interfaces[0])
+    __assert_vlan(result.interfaces[1])
+    __assert_vpc(result.interfaces[2])
+
+    result = linode.upgrade_interfaces(config=config)
+
+    assert not result.dry_run
+    assert result.config_id == config.id
+
+    __assert_public(result.interfaces[0])
+    __assert_vlan(result.interfaces[1])
+    __assert_vpc(result.interfaces[2])
+
+    __assert_public(linode.interfaces[0])
+    __assert_vlan(linode.interfaces[1])
+    __assert_vpc(linode.interfaces[2])
+
+
 def test_config_update_interfaces(create_linode):
     linode = create_linode
     config = linode.configs[0]