-
Notifications
You must be signed in to change notification settings - Fork 75
Added support for DB Configurable Params #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ezilber-akamai
merged 13 commits into
linode:proj/configurable-db-params
from
ezilber-akamai:TPT-3560-configurable-db-params
May 6, 2025
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4b5f5a3
Added support for DB Configurable Params features
ezilber-akamai f474d1c
Added unit tests for config endpoints
ezilber-akamai b5e5d51
Added more unit tests and removed config_update methods
ezilber-akamai a558167
Removed stale fields and updated unit tests
ezilber-akamai 92d4a41
Add integration tests
ykim-akamai 2a814b5
Add integration tests
ykim-akamai 5ae4622
remove unused var
ykim-akamai 18faf6a
remove comments and update test case
ykim-akamai 2d24c32
update test case
ykim-akamai 9ebc6cb
remove assertion
ykim-akamai f929568
Added support for custom JSON field names in dataclasses
ezilber-akamai 39d142b
Minor integration test fixes
ezilber-akamai 701e3c6
add get and list test cases
ykim-akamai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these fields correspond to the fields returned by
DatabaseGroup(...).mysql_config_options()
?I think having explicit fields is still the right call if so, but we also need to make sure (unit test?) users can access any fields added to that endpoint in the future. Typically I would think this is something we just update as we go, but there being a dedicated endpoint to return fields make me think these changes could happen outside of an API release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, yes, it is the same fields returned by
mysql_config_options()
. That endpoint returns additional information about the fields too (min, max, description, example, etc.). I would hope that new fields wouldn't be added outside of an API release but if you think that is a possibility, then I may have to rethink my design.