Implement _serialize(...) override in NodeBalancerConfig #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
requested review from
jriddle-linode,
ezilber-akamai and
zliang-akamai
and removed request for
a team and
jriddle-linode
zliang-akamai
approved these changes
May 21, 2025
ezilber-akamai
approved these changes
May 21, 2025
lgarber-akamai
added a commit
that referenced
this pull request
May 27, 2025
* Add support for Nodebalancers UDP (#494) * Implemented changes for NodeBalancers UDP * Added unit tests * Fix lint * Fixed issue with cipher_suite in save * Lint * Addressed PR comments * Removed overriden _serialize method * Drop residual prints * Implement _serialize(...) override in NodeBalancerConfig (#555) * Add LA notice --------- Co-authored-by: Jacob Riddle <87780794+jriddle-linode@users.noreply.github.com> Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> Co-authored-by: Ye Chen <127243817+yec-akamai@users.noreply.github.com> Co-authored-by: Youjung Kim <126618609+ykim-1@users.noreply.github.com> Co-authored-by: Erik Zilber <ezilber@akamai.com> Co-authored-by: Youjung Kim <126618609+ykim-akamai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request overrides the
NodeBalancerConfig(...)._serialize(...)method to remove the thecipher_suitefield from the PUT request body on calls tosave(...)for UDP configs. This field is rejected by the API if thecipher_suitekey is specified, even if its value isnull.✔️ How to Test
The following test steps assume you have pulled down this PR locally and your local environment is pointing to a NodeBalancer-UDP-enabled Linode account.
Unit Testing
Integration Testing
Manual Testing
N/A