upcoming: [DI-28227] - Integrating Firewall-nodebalancers to ACLP-Alerting

[santoshp210-akamai]

Description 📝

Integrating Firewall nodebalancers to ACLP-Alerting

Changes 🔄

List any change(s) relevant to the reviewer.

• Add EntityTypeSelect shown when Service is Firewall
• Filter the contents in Entity table and Dimension filter based on the entity type
• Run NodeBalancer query only when dimensions contain nodebalancer_id
• Build id to label map and use it in Alert Show Detail
• Unit tests and mock updates for translation and filtering

Scope 🚢

Upon production release, changes in this PR will be visible to:

• All customers
• Some customers (e.g. in Beta or Limited Availability)
• No customers / Not applicable

Target release date 🗓️

26th Nov

Preview 📷

Before	After

Firewall-Entity-Scope.mp4

Firewall-Account-Scope.mp4

Firewall-Edit-Flow.mp4

How to test 🧪

Prerequisites

(How to setup test environment)

Prerequisites

Choose the Mock environment, Legacy MSW Handlers
(How to setup test environment)

Create alert flow

• In Alerts, click on Create Alert.
• Choose the Firewall service.
• Confirm EntityTypeSelect appears and can switch between Linode/NodeBalancer.

Show Details flow

• Find the Firewall - nodebalancer alert in Alerts list.
• Open Show-Details: confirm NodeBalancer IDs are shown as labels (not raw IDs).

Edit alert flow

• Find the Firewall - nodebalancer alert in Alerts list.
• Open Edit: confirm entity selection and filters persist and work for NodeBalancers.

Reproduction steps

(How to reproduce the issue, if applicable)

• ...
• ...

Verification steps

(How to verify changes)

• EntityType select is visible in Firewall service
• The Entity/Account shows Firewalls filtered according to the selected entity type.
• The options in Metric Criteria Data Field are filtered according to the selected entity type.
• Entity type is not sent or received as part of any API request.
• The nodebalancer specific dimension filter customizations is working as expected.
• Entity Type is auto selected in Edit page based on the Metric Data Field name.
• Changing entity type resets the Metric Criteria

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

• I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

• All tests and CI checks are passing
• TypeScript compilation succeeded without errors
• Code passes all linting rules

[ankita-akamai]

Track this pr - #13088, update current pr after link pr is merged.

[venkymano-akamai]

just passing isDisabled doesn't work?

[venkymano-akamai]

Suggested change

	? alertDetails.rule_criteria.rules[0]?.label.includes('Node Balancer')
	? 'nodebalancer'
	: 'linode'
	? alertDetails.rule_criteria.rules[0]?.label.includes(entityLabelMap['nodebalancer'])
	? 'nodebalancer'
	: 'linode'

lets use the constant

[venkymano-akamai]

Suggested change

	filteredData = data.filter((metric) =>
	filteredData = data.filter(({label}) =>

[venkymano-akamai]

Approving, pending some comments

[dwiley-akamai]

Verification steps ✅
Code review ✅

Approved pending resolution of previous comments & the merge conflict

[linode-gh-bot]

Cloud Manager UI test results

🔺 1 failing test on test run #9 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
1 Failing	861 Passing	11 Skipped	38m 42s

Details

Failing Tests
	Spec	Test
❌	clone-linode.spec.ts	Cloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

[ankita-akamai]

Merging as there are enough approvals and failures are unrelated.