Implement webauthn-extensions. #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iinuwa
approved these changes
May 19, 2025
This was referenced May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement various extensions that are now supported by libwebauthn.
I also moved some structs that are only needed for the platform-authenticator there, as most serializing is now done by libwebauthn and there is no need to have those struct definitions there anymore.
This is still not perfect, as I don't have all the required checks that the platform is supposed to do in there, yet (e.g. the RP sending A and B, if only one or the other is officially allowed. Right now, I only ignore the irrelevant requests instead of erroring out).