Skip to content

Implement getClientCapabilities #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 21, 2025
Merged

Implement getClientCapabilities #17

merged 5 commits into from
May 21, 2025

Conversation

msirringhaus
Copy link
Collaborator

All capabilities are false for now, I think.

@iinuwa
Copy link
Member

iinuwa commented May 20, 2025

Fixes #13.

All capabilities are false for now, I think.

Yup. Code looks good; I'll test and merge later.

@iinuwa iinuwa changed the title Fix #13: Implement getClientCapabilities Implement getClientCapabilities May 20, 2025
iinuwa
iinuwa approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@iinuwa iinuwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple changes:

  • use camelCase for field names to follow the WebAuthn spec and D-Bus naming conventions
  • Use cloneInto in content script so site can read response
  • Add tests

@iinuwa
Copy link
Member

iinuwa commented May 21, 2025

I'll fix the old version of Meson later. Merging. Thanks!

@iinuwa iinuwa merged commit 63ec9a0 into linux-credentials:main May 21, 2025
1 check failed
@iinuwa iinuwa mentioned this pull request May 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iinuwa iinuwa iinuwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msirringhaus @iinuwa