Fix owner issues #21
Draft
Fix owner issues #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syscall.Chown requires root permissions. With this, tests can replace it with a dummy function.
Comment on lines
+11
to
+34
| func CarbonCopyRecursive(from, to string) error { | ||
|
|
||
| err := fs.WalkDir(os.DirFS(from), ".", func(path string, d fs.DirEntry, err error) error { | ||
| if err != nil { | ||
| return fmt.Errorf("can't search path \"%s\": %w", path, err) | ||
| } | ||
|
|
||
| from := filepath.Join(from, path) | ||
| to := filepath.Join(to, path) | ||
|
|
||
| err = CarbonCopy(from, to) | ||
| if err != nil { | ||
| return fmt.Errorf("can't copy \"%s\": %w", path, err) | ||
| } | ||
|
|
||
| return nil | ||
| }) | ||
|
|
||
| if err != nil { | ||
| return fmt.Errorf("can't copy all files: %w", err) | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
Everything looks good, I just have a doubt here. If the root folder does not exist for some rasons, it won't be created with this change. Am I wrong?
There was a problem hiding this comment.
fs.WalkDir starts with the "." path, so it will be copied from the old upper etc.
But you're right, if the old upper etc doesn't exist then it would fail. I should probably add os.MkdirAll for the folders to ensure they all exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation has a huge oversight. If the uids in the image change, which they regularly do, they also change on the installed system.
This is a very big problem since it means that system services will not have access to the right folders in that case.
More information about this can be found here: Vanilla-OS/ABRoot#419
This PR is a complete rework of EtcBuilder which has logic that dynamically adds new users and groups from the image/lower dir. It also changes the owner and group of the lower files to adjust them to the specific system they're on.
A rework was needed since it would have been very messy to implement this with the old structure. The API does stay the same, except for the settings file for "special Files", which doesn't exist anymore.