refactor: handle INJECT_FACTS_AS_VARS=false by using ansible_facts instead

Ansible 2.20 has deprecated the use of Ansible facts as variables.  For
example, `ansible_distribution` is now deprecated in favor of
`ansible_facts["distribution"]`.  This is due to making the default
setting `INJECT_FACTS_AS_VARS=false`.  For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson <rmeggins@redhat.com>

Author: richm

tests/tasks/assert_certificate_parameters.yml

@@ -26,8 +26,8 @@
         use: "{{ (__certificate_is_ostree | d(false)) |
           ternary('ansible.posix.rhel_rpm_ostree', omit) }}"
       when:
-        - ansible_distribution_major_version == "7"
-        - ansible_os_family == "RedHat"
+        - ansible_facts["distribution_major_version"] == "7"
+        - ansible_facts["os_family"] == "RedHat"
 
     - name: Ensure python3 is installed
       package:
@@ -37,8 +37,8 @@
         use: "{{ (__certificate_is_ostree | d(false)) |
           ternary('ansible.posix.rhel_rpm_ostree', omit) }}"
       when:
-        - ansible_distribution_major_version != "7"
-        - ansible_os_family == "RedHat"
+        - ansible_facts["distribution_major_version"] != "7"
+        - ansible_facts["os_family"] == "RedHat"
 
     - name: Retrieve certificate file stats
       stat:

tests/tasks/setup_ipa.yml

@@ -67,20 +67,20 @@
   hostname:
     name: ipaserver.test.local
     use: systemd
-  when: ansible_facts.os_family == "RedHat"
+  when: ansible_facts["os_family"] == "RedHat"
 
 - name: Ensure nss package is up-to-date
   package:
     name: nss
     state: latest  # noqa package-latest
     use: "{{ (__certificate_is_ostree | d(false)) |
       ternary('ansible.posix.rhel_rpm_ostree', omit) }}"
-  when: ansible_facts.os_family == "RedHat"
+  when: ansible_facts["os_family"] == "RedHat"
 
 - name: Sanitize /etc/hosts
   ansible.builtin.lineinfile:
     path: /etc/hosts
-    regexp: "{{ ansible_default_ipv4.address }}"
+    regexp: "{{ ansible_facts['default_ipv4'].address }}"
     state: absent
     owner: root
     group: root
@@ -91,7 +91,7 @@
 - name: Add host to /etc/hosts
   ansible.builtin.lineinfile:
     path: /etc/hosts
-    line: "{{ ansible_default_ipv4.address }}  ipaserver.test.local"
+    line: "{{ ansible_facts['default_ipv4'].address }}  ipaserver.test.local"
     state: present
     insertafter: EOF
     create: true

tests/tests_basic_ipa.yml

@@ -104,4 +104,4 @@
       hostname:
         name: "{{ __saved_hostname.stdout }}"
         use: systemd
-      when: ansible_facts.os_family == "RedHat"
+      when: ansible_facts["os_family"] == "RedHat"

tests/tests_include_vars_from_parent.yml

@@ -30,10 +30,10 @@
         # create all variants like CentOS, CentOS_8.1, CentOS-8.1,
         # CentOS-8, CentOS-8.1
         # more formally:
-        # {{ ansible_distribution }}-{{ ansible_distribution_version }}
-        # {{ ansible_distribution }}-{{ ansible_distribution_major_version }}
-        # {{ ansible_distribution }}
-        # {{ ansible_os_family }}
+        # {{ ansible_facts['distribution'] }}-{{ ansible_facts['distribution_version'] }}
+        # {{ ansible_facts['distribution'] }}-{{ ansible_facts['distribution_major_version'] }}
+        # {{ ansible_facts['distribution'] }}
+        # {{ ansible_facts['os_family'] }}
         # and the same for _ as separator.
         varfiles: "{{ [facts['distribution']] | product(separators) |
           map('join') | product(versions) | map('join') | list +

tests/tests_subject_complex.yml

@@ -35,8 +35,8 @@
     - name: Verify certs if not CentOS/RedHat 7
       when: |
         not (
-            ansible_distribution in ['CentOS', 'RedHat'] and
-            ansible_distribution_major_version == "7"
+            ansible_facts["distribution"] in ['CentOS', 'RedHat'] and
+            ansible_facts["distribution_major_version"] == "7"
         )
       block:
         - name: Verify each certificate

tests/vars/rh_distros_vars.yml

@@ -14,7 +14,7 @@ __certificate_rh_distros:
 __certificate_rh_distros_fedora: "{{ __certificate_rh_distros + ['Fedora'] }}"
 
 # Use this in conditionals to check if distro is Red Hat or clone
-__certificate_is_rh_distro: "{{ ansible_distribution in __certificate_rh_distros }}"
+__certificate_is_rh_distro: "{{ ansible_facts['distribution'] in __certificate_rh_distros }}"
 
 # Use this in conditionals to check if distro is Red Hat or clone, or Fedora
-__certificate_is_rh_distro_fedora: "{{ ansible_distribution in __certificate_rh_distros_fedora }}"
+__certificate_is_rh_distro_fedora: "{{ ansible_facts['distribution'] in __certificate_rh_distros_fedora }}"

vars/main.yml

@@ -48,8 +48,8 @@ __certificate_rh_distros:
 __certificate_rh_distros_fedora: "{{ __certificate_rh_distros + ['Fedora'] }}"
 
 # Use this in conditionals to check if distro is Red Hat or clone
-__certificate_is_rh_distro: "{{ ansible_distribution in __certificate_rh_distros }}"
+__certificate_is_rh_distro: "{{ ansible_facts['distribution'] in __certificate_rh_distros }}"
 
 # Use this in conditionals to check if distro is Red Hat or clone, or Fedora
-__certificate_is_rh_distro_fedora: "{{ ansible_distribution in __certificate_rh_distros_fedora }}"
+__certificate_is_rh_distro_fedora: "{{ ansible_facts['distribution'] in __certificate_rh_distros_fedora }}"
 # END - DO NOT EDIT THIS BLOCK - rh distros variables