Skip to content

Commit 5574fb4

Browse files
committed
Makefile modules/coreboot modules/nvmutil: remove unneeded ifdutil/cbfsutil/nvmutil for this task.
cbmem+cbfs is enough Signed-off-by: Thierry Laurion <insurgo@riseup.net>
1 parent aec79eb commit 5574fb4

File tree

3 files changed

+0
-34
lines changed

3 files changed

+0
-34
lines changed

Makefile

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,6 @@ bin_modules-$(CONFIG_ZSTD) += zstd
573573
bin_modules-$(CONFIG_E2FSPROGS) += e2fsprogs
574574
bin_modules-$(CONFIG_EXFATPROGS) += exfatprogs
575575
bin_modules-$(CONFIG_IOTOOLS) += iotools
576-
bin_modules-$(CONFIG_NVMUTIL) += nvmutil
577576

578577
$(foreach m, $(bin_modules-y), \
579578
$(call map,initrd_bin_add,$(call bins,$m)) \
@@ -594,21 +593,11 @@ ifeq ($(CONFIG_COREBOOT),y)
594593
$(eval $(call initrd_bin_add,$(COREBOOT_UTIL_DIR)/cbmem/cbmem))
595594
#$(eval $(call initrd_bin_add,$(COREBOOT_UTIL_DIR)/superiotool/superiotool))
596595
#$(eval $(call initrd_bin_add,$(COREBOOT_UTIL_DIR)/inteltool/inteltool))
597-
ifeq ($(CONFIG_NVMUTIL),y)
598-
#NVMUTIL(nvm) is applied on ifdtool extracted gbe.bin from a flashrom backup under Heads.
599-
# We consequently need ifdtool packed under initrd with cross-compiler
600-
# coreboot module copied ifdtool into ifdtool_cross at configure step
601-
# so that coreboot builds its own and we ask one to be cross-build and packed here
602-
$(eval $(call initrd_bin_add,$(COREBOOT_UTIL_DIR)/ifdtool_cross/ifdtool))
603-
$(eval $(call initrd_bin_add,$(COREBOOT_UTIL_DIR)/cbfstool_cross/cbfstool))
604-
endif
605596
endif
606597

607598
$(COREBOOT_UTIL_DIR)/cbmem/cbmem \
608599
$(COREBOOT_UTIL_DIR)/superiotool/superiotool \
609600
$(COREBOOT_UTIL_DIR)/inteltool/inteltool \
610-
$(COREBOOT_UTIL_DIR)/ifdtool_cross/ifdtool \
611-
$(COREBOOT_UTIL_DIR)/cbfstool_cross/cbfstool \
612601
: $(build)/$(coreboot_base_dir)/.canary musl-cross
613602
+$(call do,MAKE,$(notdir $@),\
614603
$(MAKE) -C "$(dir $@)" $(CROSS_TOOLS) \

modules/coreboot

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,6 @@ $(coreboot_module)_configure := \
138138
&& $(call install_config,$(pwd)/$(CONFIG_COREBOOT_CONFIG),$(build)/$(coreboot_dir)/.config) \
139139
&& echo 'CONFIG_LOCALVERSION="$(BRAND_NAME)-$(HEADS_GIT_VERSION)"' >> $(build)/$(coreboot_dir)/.config \
140140
&& echo 'CONFIG_MAINBOARD_SMBIOS_PRODUCT_NAME="$(BOARD)"' >> $(build)/$(coreboot_dir)/.config \
141-
&& cp -TRf --remove-destination $(build)/$(coreboot_base_dir)/util/ifdtool $(build)/$(coreboot_base_dir)/util/ifdtool_cross \
142-
&& cp -TRf --remove-destination $(build)/$(coreboot_base_dir)/util/cbfstool $(build)/$(coreboot_base_dir)/util/cbfstool_cross \
143141
&& $(MAKE) olddefconfig \
144142
-C "$(build)/$(coreboot_base_dir)" \
145143
obj="$(build)/$(coreboot_dir)" \

modules/nvmutil

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)