-
Couldn't load subscription status.
- Fork 579
hijir@mushi: initial release #7360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "author": "Mushi", | ||
| "applets": [ | ||
| { | ||
| "name": "Hijri Date", | ||
| "uuid": "hijri@mushi", | ||
| "description": "Show Hijri date in the panel.", | ||
| "settings-schema": "settings-schema.json" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "author": "Mushi", | |
| "applets": [ | |
| { | |
| "name": "Hijri Date", | |
| "uuid": "hijri@mushi", | |
| "description": "Show Hijri date in the panel.", | |
| "settings-schema": "settings-schema.json" | |
| } | |
| ] | |
| "author": "mubashirzamir" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I've closed the request after noticing the typos in my commit message and post title. Will make a new PR and post a link here as well. Apologies.
|
Typo in title and commit messages. |
You can fix this without having to create another pull request. |
|
Ahh, realized it too late unfortunately. I wanted my first PR to be totally in line with the guidelines. I started fresh: #7361 Apologies again. |
There are no guidelines that prohibit additional commits, edits, or rebasing. On the contrary, it means less sprawl for a single line of activity. |
|
Very true. I was too fixated on the format in the following point to realize that:
There was guide on changing commit messages right after it 😑:
|
Displays the current Hijri (Islamic) date using the Aladhan API.