Skip to content

Conversation

@mubashirzamir
Copy link

Displays the current Hijri (Islamic) date using the Aladhan API.

Comment on lines +7 to +15
"author": "Mushi",
"applets": [
{
"name": "Hijri Date",
"uuid": "hijri@mushi",
"description": "Show Hijri date in the panel.",
"settings-schema": "settings-schema.json"
}
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"author": "Mushi",
"applets": [
{
"name": "Hijri Date",
"uuid": "hijri@mushi",
"description": "Show Hijri date in the panel.",
"settings-schema": "settings-schema.json"
}
]
"author": "mubashirzamir"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I've closed the request after noticing the typos in my commit message and post title. Will make a new PR and post a link here as well. Apologies.

@mubashirzamir
Copy link
Author

Typo in title and commit messages.

@rcalixte
Copy link
Member

Typo in title and commit messages.

You can fix this without having to create another pull request.

@mubashirzamir
Copy link
Author

Ahh, realized it too late unfortunately. I wanted my first PR to be totally in line with the guidelines. I started fresh: #7361

Apologies again.

@rcalixte
Copy link
Member

I wanted my first PR to be totally in line with the guidelines.

There are no guidelines that prohibit additional commits, edits, or rebasing. On the contrary, it means less sprawl for a single line of activity.

@mubashirzamir
Copy link
Author

Very true. I was too fixated on the format in the following point to realize that:

It's important to use a proper title in the commit messages and pull requests. The title must be in the format spice name: simple description, what the commit/pull request does.

There was guide on changing commit messages right after it 😑:

How to change the commit message (https://help.github.com/articles/changing-a-commit-message/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants