feat(cli-config): generate QA preview URLs by pipeline BM-1407 #3559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This piece of work stems from the fix/import-diff-command branch.
I've created this pull request separately so you can see this work's changes more easily.
Motivation
Our basemaps-config preview links for Elevation inserts don’t show anything in Basemaps. You can’t see the imagery until you add the following parameters:
We need to update the cli-config package’s import command to add the
pipelineandformatkey-value parameters automatically.Approach
Update the code that generates the basemaps-config preview links to provide links for all supported pipelines based on the dataset type.
color-rampandterrain-rgb.Modifications
packages/cli-config/src/cli/
action.import.tsUpdated the
prepareUrlsfunction to return an object of the following type:For
Aerialimagery, that will look something like this:For
Elevationimagery, that will look something like this:Updated the
outputNewLayersandoutputUpdatedLayersfunctions to simplify the code for capturing2193and3857changes. Also, re-styled the markdown generated by each function respectively (example below).Updated the
outputChangefunction to re-style each major markdown section into a collapsible<details>element (example below).Verification
I attempted to put together a test suite to validate the behaviour of the
prepareUrlsfunction. However, I couldn't get it working correctly.In lieu, here's an example of the updated markdown generated by the cli-config package’s
importcommand. I've removed theconfigparameter from each URL so that you can preview them:🟡🟡 Aerial Imagery Updates 🟡🟡
gebco-2020-305.75m
GEBCO Gridded Bathymetry (2020)
Individual Updates
thames_2017-2019_dsm_1m
Waikato - Thames LiDAR 1m DSM (2017-2019)