Skip to content

Conversation

@winstxnhdw
Copy link

@winstxnhdw winstxnhdw commented Oct 17, 2025

Summary by Sourcery

Migrate Python packaging and workflow from Poetry to uv by converting to PEP621 metadata, updating build-system and build scripts, adjusting CI actions, and revising documentation accordingly while expanding supported Python versions.

Enhancements:

  • Add support for Python versions 3.12 through 3.14 in classifiers

Build:

  • Convert pyproject.toml from Poetry-specific to PEP621 [project] table with dynamic versioning
  • Update build-system maturin requirement to >=1.9.6 and configure extension module features

CI:

  • Replace Poetry setup with uv installer in GitHub Actions and rename python_tests job
  • Configure uv environment activation and caching for dependencies
  • Use uv run for maturin, pytest, and benchmark commands in CI

Documentation:

  • Update README installation and command references to use uv instead of Poetry

Chores:

  • Update Cargo.toml repository URL to the litestar namespace

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 17, 2025

Reviewer's Guide

This PR replaces Poetry-based build and dependency management with uv by migrating project metadata to PEP 621, defining uv-managed dependency groups, updating build-system and CI workflows to use uv commands, and adjusting documentation and lockfiles accordingly.

Flow diagram for migration from Poetry to uv in project setup

flowchart TD
  A["Project uses Poetry for dependency management"] --> B["Remove Poetry configuration from pyproject.toml"]
  B --> C["Add PEP 621 project metadata"]
  C --> D["Define dependency groups for uv"]
  D --> E["Add uv.lock file and remove poetry.lock"]
  E --> F["Update documentation and CI to use uv commands"]
Loading

File-Level Changes

Change Details Files
Migrate pyproject.toml from Poetry to PEP 621 and uv management
  • Replace [tool.poetry] table with [project] metadata and dynamic version
  • Move dev dependencies into dependency-groups.dev under uv conventions
  • Update build-system maturin version and enable extension-module feature
  • Remove Poetry-specific tool configs (black) and consolidate ruff settings
  • Extend Python classifiers to include 3.12–3.14
pyproject.toml
Revamp CI workflows to use uv instead of Poetry
  • Fix typo in tests job name
  • Switch Poetry install steps to astral-sh/setup-uv action
  • Use uv pip install, uv run maturin, and uv run pytest
  • Cache dependencies via uv.lock instead of Poetry lockfile
.github/workflows/ci.yaml
Update README usage examples to uv commands
  • Change setup instruction from poetry install to uv sync
  • Replace build and benchmark commands to use uv run
README.md
Switch lockfile from poetry.lock to uv.lock
  • Remove poetry.lock and add uv.lock
  • Exclude uv.lock in maturin config
poetry.lock
uv.lock
Correct repository URL in Cargo.toml
  • Update repository field to litestar organization URL
Cargo.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Blocking issues:

  • An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.github/workflows/ci.yaml:44` </location>
<code_context>
        uses: astral-sh/setup-uv@v7.1.0
</code_context>

<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

*Source: opengrep*
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we compatible/releasing for 3.14?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my 3.14 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants