-
-
Notifications
You must be signed in to change notification settings - Fork 7
build: migrate from poetry to uv
#33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideThis PR replaces Poetry-based build and dependency management with uv by migrating project metadata to PEP 621, defining uv-managed dependency groups, updating build-system and CI workflows to use uv commands, and adjusting documentation and lockfiles accordingly. Flow diagram for migration from Poetry to uv in project setupflowchart TD
A["Project uses Poetry for dependency management"] --> B["Remove Poetry configuration from pyproject.toml"]
B --> C["Add PEP 621 project metadata"]
C --> D["Define dependency groups for uv"]
D --> E["Add uv.lock file and remove poetry.lock"]
E --> F["Update documentation and CI to use uv commands"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Blocking issues:
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/ci.yaml:44` </location>
<code_context>
uses: astral-sh/setup-uv@v7.1.0
</code_context>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Programming Language :: Python :: 3.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we compatible/releasing for 3.14?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing on my 3.14 build.
Summary by Sourcery
Migrate Python packaging and workflow from Poetry to uv by converting to PEP621 metadata, updating build-system and build scripts, adjusting CI actions, and revising documentation accordingly while expanding supported Python versions.
Enhancements:
Build:
CI:
Documentation:
Chores: