Skip to content

Added a brandmark / logo and adjusted css #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbsouth
Copy link

@mbsouth mbsouth commented Apr 25, 2025

modified:
public/css/main.css
modified: public/css/mainmenu.css
modified: template.html

@liuch
Copy link
Owner

liuch commented Apr 28, 2025

I looked at your PR and I have a few comments:

  • Twitchy animation of the menu button
  • Header H1 jerks when the menu starts moving to the right
  • Blank space at the top of activated menu, the position of the menu close button when the menu is active looks strange
  • The button visually blends in with the adjacent header (h1) because of the same color
  • Spaces in *.css and template.html files, there should be tabs as in the rest of the lines (code style)
  • Trailing spaces in mainmenu.css (five lines)

Could you please fix that?

Just a couple more questions:

  • Why was it necessary to change the animation?
  • I also noticed that you replaced one
    element with three elements in the template.html file. Was there really a reason for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants