[TOSA] Add F16 and BF16 support for tosa.clamp #4281
+80
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Ngo <justin.ngo@arm.com> Change-Id: I0f1ed0249018b40d068af3a2d02a93776c0c4a5f
justin-ngo-arm
commented
Jul 23, 2025
| @@ -31,6 +31,20 @@ | |||
|
|
|||
| #include "mlir/Dialect/Tosa/Utils/QuantUtils.h" | |||
|
|
|||
| namespace { | |||
|
|
|||
| namespace limits { | |||
There was a problem hiding this comment.
Is this a proper place to define these constants? I plan to use them within TorchToTosa.cpp only, but they are not TOSA-specific constants.
There was a problem hiding this comment.
@vivekkhandelwal1 do you have any suggestions here ?
|
Hi @sjarus / @justin-ngo-arm, I'm on vacation through end of next week. So I won't be able to do a timely review on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add F16 and BF16 for torch ops that are lowered to
tosa.clamp